Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plugins/stewards/migrations.snapshot.json
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,8 @@
"8503121de463ec77e923cbf67bead9d573c0d28343bbc147e14a4284e50d88cb",
"b2b3d782a63c5bb74d8ffc09274a0a816c247ff1786bed261f484241d38ed003",
"5f7f3062ec065532a809197f70ab75aac9150503518c8c28b2be94640cd8c942",
"64d043c0410e462351414e5acd8557d077ee1ca059ccf0e97ea50ef503f4e666"
"64d043c0410e462351414e5acd8557d077ee1ca059ccf0e97ea50ef503f4e666",
"00a95665ae9de85807efa76a7a72b7567c664b0295c90ebd5a544ab82ce643ea",
"4ef374ea156dddb2cddbfe2eebefb69eb194e22fb19e3cd33e0d368b740e2f5c",
"719d996e69cf67362f4969245bf0eed33d9239d671b80f4ba6b763782404028c"
]
6 changes: 5 additions & 1 deletion plugins/stewards/read-counts.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,11 @@ describe("a reconcile pass over a fixed binding set (BB-297)", () => {
// BB-329 lowered them 194 → 193: the merge gate's `parkedWorkerOwnsAnother`
// now reads the parked state from the one assessment the reconcile already
// built, instead of calling `store.workers(b.id)` a second time.
expect(reconcile).toEqual({ storeReads: 193, sourceCalls: 12, reconciles: 4, bindings: 4 });
// BB-386 raised them 193 → 197: `pullBelongsToTicket` reads the pull
// request's handoff row (cached after the first read) so a moved pull
// request belongs to its new binding — three own pull requests — and
// `reconcileOnce` reads the handed-off pull list once for the pass.
expect(reconcile).toEqual({ storeReads: 197, sourceCalls: 12, reconciles: 4, bindings: 4 });
expect(wake).toEqual({ storeReads: 15, sourceCalls: 0, wakes: 1 });
});

Expand Down
286 changes: 285 additions & 1 deletion plugins/stewards/server.test.ts

Large diffs are not rendered by default.

338 changes: 321 additions & 17 deletions plugins/stewards/server.ts

Large diffs are not rendered by default.

12 changes: 8 additions & 4 deletions plugins/stewards/store.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Database from "better-sqlite3";
import { describe, expect, it } from "vitest";
import { z } from "zod";
import { ACTOR_MIGRATIONS, ALERTMANAGER_LOOK_MIGRATIONS, BACKLOG_LOOK_MIGRATIONS, BACKLOG_SNAPSHOT_MIGRATIONS, BACKLOG_WRITE_MIGRATIONS, CHECK_FINDING_MIGRATIONS, ESCALATION_REWAKE_MIGRATIONS, HUDDLE_MIGRATIONS, LEARNED_SLACK_MIGRATIONS, LOCAL_TICKET_MIGRATIONS, NON_ACTION_MIGRATIONS, PLAYBOOK_REFRESH_MIGRATIONS, TYPED_WAIT_MIGRATIONS, WAIT_BUDGET_MIGRATIONS, WAIT_SLACK_MIGRATIONS, WAIT_DIVERGENCE_MIGRATIONS, APPROVAL_MARKER_MIGRATIONS, ASSESSMENT_MIGRATIONS, ASSUMPTION_MIGRATIONS, BASE_MIGRATIONS, CHAIN_MIGRATIONS, DATED_WAIT_MIGRATIONS, DEPS_DECISION_MIGRATIONS, ENDED_READ_MIGRATIONS, ESCALATION_ROUTE_MIGRATIONS, GUIDANCE_MIGRATIONS, IDLE_MIGRATIONS, LESSON_COUNTER_MIGRATIONS, LESSON_PR_MIGRATIONS, LESSON_TIER_MIGRATIONS, MERGE_BEHIND_MIGRATIONS, MIGRATIONS, PULL_REQUESTER_MIGRATIONS, PULL_WATCH_MIGRATIONS, RATIONALE_MIGRATIONS, RETARGET_PULLS_MIGRATIONS, REVIEWER_MODEL_MIGRATIONS, REVIEWER_REQUEST_MIGRATIONS, SERVER_SETTINGS_MIGRATIONS, STACK_MIGRATIONS, STACKED_PULLS_MIGRATIONS, VALIDATION_MIGRATIONS, WAKE_RETRY_MIGRATIONS, WAKE_SOURCE_MIGRATIONS, WORKER_CHECK_MIGRATIONS, STANDUP_MIGRATIONS, STANDUP_BINDING_MIGRATIONS, STANDUP_DELEGATION_MIGRATIONS, STANDUP_COMPLETED_MIGRATIONS, WORKER_STOP_REASON_MIGRATIONS, WORKER_PARK_MIGRATIONS, createStore, lessonScope, statusRecordSchema, type Binding } from "./store.js";
import { ACTOR_MIGRATIONS, ALERTMANAGER_LOOK_MIGRATIONS, BACKLOG_LOOK_MIGRATIONS, BACKLOG_SNAPSHOT_MIGRATIONS, BACKLOG_WRITE_MIGRATIONS, CHECK_FINDING_MIGRATIONS, ESCALATION_REWAKE_MIGRATIONS, HUDDLE_MIGRATIONS, LEARNED_SLACK_MIGRATIONS, LOCAL_TICKET_MIGRATIONS, NON_ACTION_MIGRATIONS, PLAYBOOK_REFRESH_MIGRATIONS, TYPED_WAIT_MIGRATIONS, WAIT_BUDGET_MIGRATIONS, WAIT_SLACK_MIGRATIONS, WAIT_DIVERGENCE_MIGRATIONS, APPROVAL_MARKER_MIGRATIONS, ASSESSMENT_MIGRATIONS, ASSUMPTION_MIGRATIONS, BASE_MIGRATIONS, CHAIN_MIGRATIONS, DATED_WAIT_MIGRATIONS, DEPS_DECISION_MIGRATIONS, ENDED_READ_MIGRATIONS, ESCALATION_ROUTE_MIGRATIONS, GUIDANCE_MIGRATIONS, HANDOFF_MIGRATIONS, REHOME_MARK_MIGRATIONS, IDLE_MIGRATIONS, LESSON_COUNTER_MIGRATIONS, LESSON_PR_MIGRATIONS, LESSON_TIER_MIGRATIONS, MERGE_BEHIND_MIGRATIONS, MIGRATIONS, PULL_REQUESTER_MIGRATIONS, PULL_WATCH_MIGRATIONS, RATIONALE_MIGRATIONS, RETARGET_PULLS_MIGRATIONS, REVIEWER_MODEL_MIGRATIONS, REVIEWER_REQUEST_MIGRATIONS, SERVER_SETTINGS_MIGRATIONS, STACK_MIGRATIONS, STACKED_PULLS_MIGRATIONS, VALIDATION_MIGRATIONS, WAKE_RETRY_MIGRATIONS, WAKE_SOURCE_MIGRATIONS, WORKER_CHECK_MIGRATIONS, STANDUP_MIGRATIONS, STANDUP_BINDING_MIGRATIONS, STANDUP_DELEGATION_MIGRATIONS, STANDUP_COMPLETED_MIGRATIONS, WORKER_STOP_REASON_MIGRATIONS, WORKER_PARK_MIGRATIONS, createStore, lessonScope, statusRecordSchema, type Binding } from "./store.js";

/** MIGRATIONS without the groups appended after the ones these order tests assert. */
const beforeActorMigrations = MIGRATIONS.slice(0, MIGRATIONS.indexOf(ACTOR_MIGRATIONS[0]!));
Expand Down Expand Up @@ -750,7 +750,7 @@ describe("the actor rename migration (BB-97)", () => {
// BB-341's backlog-writes ledger after that, and BB-351's wait-budget
// columns after that. BB-354's wait-slacked column followed, and BB-358's
// learned-Slack tables are the newest.
const groups = [ESCALATION_REWAKE_MIGRATIONS, LOCAL_TICKET_MIGRATIONS, LEARNED_SLACK_MIGRATIONS, WAIT_SLACK_MIGRATIONS, WAIT_BUDGET_MIGRATIONS, BACKLOG_WRITE_MIGRATIONS, PLAYBOOK_REFRESH_MIGRATIONS, WAIT_DIVERGENCE_MIGRATIONS, NON_ACTION_MIGRATIONS, TYPED_WAIT_MIGRATIONS, BACKLOG_SNAPSHOT_MIGRATIONS, CHECK_FINDING_MIGRATIONS, BACKLOG_LOOK_MIGRATIONS, WORKER_PARK_MIGRATIONS, REVIEWER_REQUEST_MIGRATIONS, PULL_REQUESTER_MIGRATIONS, ALERTMANAGER_LOOK_MIGRATIONS, STANDUP_COMPLETED_MIGRATIONS, STANDUP_DELEGATION_MIGRATIONS, STANDUP_BINDING_MIGRATIONS, STANDUP_MIGRATIONS, HUDDLE_MIGRATIONS, ENDED_READ_MIGRATIONS, ASSESSMENT_MIGRATIONS, STACKED_PULLS_MIGRATIONS, RETARGET_PULLS_MIGRATIONS, MERGE_BEHIND_MIGRATIONS, WAKE_RETRY_MIGRATIONS, DATED_WAIT_MIGRATIONS, ASSUMPTION_MIGRATIONS, WORKER_STOP_REASON_MIGRATIONS, DEPS_DECISION_MIGRATIONS, ESCALATION_ROUTE_MIGRATIONS, STACK_MIGRATIONS, PULL_WATCH_MIGRATIONS, SERVER_SETTINGS_MIGRATIONS, WAKE_SOURCE_MIGRATIONS, REVIEWER_MODEL_MIGRATIONS, LESSON_PR_MIGRATIONS, ACTOR_MIGRATIONS, APPROVAL_MARKER_MIGRATIONS];
const groups = [REHOME_MARK_MIGRATIONS, HANDOFF_MIGRATIONS, ESCALATION_REWAKE_MIGRATIONS, LOCAL_TICKET_MIGRATIONS, LEARNED_SLACK_MIGRATIONS, WAIT_SLACK_MIGRATIONS, WAIT_BUDGET_MIGRATIONS, BACKLOG_WRITE_MIGRATIONS, PLAYBOOK_REFRESH_MIGRATIONS, WAIT_DIVERGENCE_MIGRATIONS, NON_ACTION_MIGRATIONS, TYPED_WAIT_MIGRATIONS, BACKLOG_SNAPSHOT_MIGRATIONS, CHECK_FINDING_MIGRATIONS, BACKLOG_LOOK_MIGRATIONS, WORKER_PARK_MIGRATIONS, REVIEWER_REQUEST_MIGRATIONS, PULL_REQUESTER_MIGRATIONS, ALERTMANAGER_LOOK_MIGRATIONS, STANDUP_COMPLETED_MIGRATIONS, STANDUP_DELEGATION_MIGRATIONS, STANDUP_BINDING_MIGRATIONS, STANDUP_MIGRATIONS, HUDDLE_MIGRATIONS, ENDED_READ_MIGRATIONS, ASSESSMENT_MIGRATIONS, STACKED_PULLS_MIGRATIONS, RETARGET_PULLS_MIGRATIONS, MERGE_BEHIND_MIGRATIONS, WAKE_RETRY_MIGRATIONS, DATED_WAIT_MIGRATIONS, ASSUMPTION_MIGRATIONS, WORKER_STOP_REASON_MIGRATIONS, DEPS_DECISION_MIGRATIONS, ESCALATION_ROUTE_MIGRATIONS, STACK_MIGRATIONS, PULL_WATCH_MIGRATIONS, SERVER_SETTINGS_MIGRATIONS, WAKE_SOURCE_MIGRATIONS, REVIEWER_MODEL_MIGRATIONS, LESSON_PR_MIGRATIONS, ACTOR_MIGRATIONS, APPROVAL_MARKER_MIGRATIONS];
let end = MIGRATIONS.length;
for (const group of groups) {
expect(MIGRATIONS.slice(end - group.length, end)).toEqual([...group]);
Expand Down Expand Up @@ -850,8 +850,12 @@ describe("the escalation route rename migration (BB-209)", () => {
// BB-328's check-findings table after that, BB-334's backlog snapshot
// column after that, and BB-333's typed wait column after that. BB-335's
// non-action column is last but for BB-333 PR 2's wait-divergence table.
const withoutEscalationRewake = MIGRATIONS.slice(0, -ESCALATION_REWAKE_MIGRATIONS.length);
expect(MIGRATIONS.slice(-ESCALATION_REWAKE_MIGRATIONS.length)).toEqual([...ESCALATION_REWAKE_MIGRATIONS]);
const withoutRehomeMark = MIGRATIONS.slice(0, -REHOME_MARK_MIGRATIONS.length);
expect(MIGRATIONS.slice(-REHOME_MARK_MIGRATIONS.length)).toEqual([...REHOME_MARK_MIGRATIONS]);
const withoutHandoff = withoutRehomeMark.slice(0, -HANDOFF_MIGRATIONS.length);
expect(withoutRehomeMark.slice(-HANDOFF_MIGRATIONS.length)).toEqual([...HANDOFF_MIGRATIONS]);
const withoutEscalationRewake = withoutHandoff.slice(0, -ESCALATION_REWAKE_MIGRATIONS.length);
expect(withoutHandoff.slice(-ESCALATION_REWAKE_MIGRATIONS.length)).toEqual([...ESCALATION_REWAKE_MIGRATIONS]);
const withoutLocal = withoutEscalationRewake.slice(0, -LOCAL_TICKET_MIGRATIONS.length);
const withoutLearnedSlack = withoutLocal.slice(0, -LEARNED_SLACK_MIGRATIONS.length);
expect(withoutLocal.slice(-LEARNED_SLACK_MIGRATIONS.length)).toEqual([...LEARNED_SLACK_MIGRATIONS]);
Expand Down
125 changes: 124 additions & 1 deletion plugins/stewards/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,36 @@ export const ESCALATION_REWAKE_MIGRATIONS = [
`ALTER TABLE bindings ADD COLUMN escalation_rewake_at INTEGER`,
];

export const MIGRATIONS = [...BASE_MIGRATIONS, ...CHAIN_MIGRATIONS, ...LESSON_COUNTER_MIGRATIONS, ...WORKER_CHECK_MIGRATIONS, ...DECLINED_PR_MIGRATIONS, ...DEPLOYMENT_MIGRATIONS, ...FINISHED_AND_DIGEST_MIGRATIONS, ...LESSON_TIER_MIGRATIONS, ...RATIONALE_MIGRATIONS, ...VALIDATION_MIGRATIONS, ...GUIDANCE_MIGRATIONS, ...IDLE_MIGRATIONS, ...APPROVAL_MARKER_MIGRATIONS, ...ACTOR_MIGRATIONS, ...LESSON_PR_MIGRATIONS, ...REVIEWER_MODEL_MIGRATIONS, ...WAKE_SOURCE_MIGRATIONS, ...SERVER_SETTINGS_MIGRATIONS, ...PULL_WATCH_MIGRATIONS, ...STACK_MIGRATIONS, ...ESCALATION_ROUTE_MIGRATIONS, ...DEPS_DECISION_MIGRATIONS, ...WORKER_STOP_REASON_MIGRATIONS, ...ASSUMPTION_MIGRATIONS, ...DATED_WAIT_MIGRATIONS, ...WAKE_RETRY_MIGRATIONS, ...MERGE_BEHIND_MIGRATIONS, ...RETARGET_PULLS_MIGRATIONS, ...STACKED_PULLS_MIGRATIONS, ...ASSESSMENT_MIGRATIONS, ...ENDED_READ_MIGRATIONS, ...HUDDLE_MIGRATIONS, ...STANDUP_MIGRATIONS, ...STANDUP_BINDING_MIGRATIONS, ...STANDUP_DELEGATION_MIGRATIONS, ...STANDUP_COMPLETED_MIGRATIONS, ...ALERTMANAGER_LOOK_MIGRATIONS, ...PULL_REQUESTER_MIGRATIONS, ...REVIEWER_REQUEST_MIGRATIONS, ...WORKER_PARK_MIGRATIONS, ...BACKLOG_LOOK_MIGRATIONS, ...CHECK_FINDING_MIGRATIONS, ...BACKLOG_SNAPSHOT_MIGRATIONS, ...TYPED_WAIT_MIGRATIONS, ...NON_ACTION_MIGRATIONS, ...WAIT_DIVERGENCE_MIGRATIONS, ...PLAYBOOK_REFRESH_MIGRATIONS, ...BACKLOG_WRITE_MIGRATIONS, ...WAIT_BUDGET_MIGRATIONS, ...WAIT_SLACK_MIGRATIONS, ...LEARNED_SLACK_MIGRATIONS, ...LOCAL_TICKET_MIGRATIONS, ...ESCALATION_REWAKE_MIGRATIONS];
// BB-386: a pull request handed from the binding that opened it to another
// binding (a `steward_report { handOff }`, or the project steward's
// `steward_update { adoptPull }`). One row per pull request key, so a handoff
// is a move, not a history; `from_binding_id` is the binding it left, for the
// record and for re-homing. `pullBelongsToTicket` reads it first, so ownership
// follows the row rather than the opening worker's branch.
export const HANDOFF_MIGRATIONS = [
`CREATE TABLE IF NOT EXISTS pull_handoffs (
pull_key TEXT PRIMARY KEY,
from_binding_id TEXT,
to_binding_id TEXT NOT NULL,
created_at INTEGER NOT NULL
)`,
`CREATE INDEX IF NOT EXISTS pull_handoffs_to ON pull_handoffs (to_binding_id)`,
];

// BB-386: an ended binding's pull request that re-homing has already looked at
// (re-homed, named in a need, or found merged/closed, or a teammate's). One row
// per (pull key, binding), so a later sweep does not re-read it; the same pull
// request under a different ended binding is still considered.
export const REHOME_MARK_MIGRATIONS = [
`CREATE TABLE IF NOT EXISTS pull_rehome_marks (
pull_key TEXT NOT NULL,
binding_id TEXT NOT NULL,
at INTEGER NOT NULL,
PRIMARY KEY (pull_key, binding_id)
)`,
];

export const MIGRATIONS = [...BASE_MIGRATIONS, ...CHAIN_MIGRATIONS, ...LESSON_COUNTER_MIGRATIONS, ...WORKER_CHECK_MIGRATIONS, ...DECLINED_PR_MIGRATIONS, ...DEPLOYMENT_MIGRATIONS, ...FINISHED_AND_DIGEST_MIGRATIONS, ...LESSON_TIER_MIGRATIONS, ...RATIONALE_MIGRATIONS, ...VALIDATION_MIGRATIONS, ...GUIDANCE_MIGRATIONS, ...IDLE_MIGRATIONS, ...APPROVAL_MARKER_MIGRATIONS, ...ACTOR_MIGRATIONS, ...LESSON_PR_MIGRATIONS, ...REVIEWER_MODEL_MIGRATIONS, ...WAKE_SOURCE_MIGRATIONS, ...SERVER_SETTINGS_MIGRATIONS, ...PULL_WATCH_MIGRATIONS, ...STACK_MIGRATIONS, ...ESCALATION_ROUTE_MIGRATIONS, ...DEPS_DECISION_MIGRATIONS, ...WORKER_STOP_REASON_MIGRATIONS, ...ASSUMPTION_MIGRATIONS, ...DATED_WAIT_MIGRATIONS, ...WAKE_RETRY_MIGRATIONS, ...MERGE_BEHIND_MIGRATIONS, ...RETARGET_PULLS_MIGRATIONS, ...STACKED_PULLS_MIGRATIONS, ...ASSESSMENT_MIGRATIONS, ...ENDED_READ_MIGRATIONS, ...HUDDLE_MIGRATIONS, ...STANDUP_MIGRATIONS, ...STANDUP_BINDING_MIGRATIONS, ...STANDUP_DELEGATION_MIGRATIONS, ...STANDUP_COMPLETED_MIGRATIONS, ...ALERTMANAGER_LOOK_MIGRATIONS, ...PULL_REQUESTER_MIGRATIONS, ...REVIEWER_REQUEST_MIGRATIONS, ...WORKER_PARK_MIGRATIONS, ...BACKLOG_LOOK_MIGRATIONS, ...CHECK_FINDING_MIGRATIONS, ...BACKLOG_SNAPSHOT_MIGRATIONS, ...TYPED_WAIT_MIGRATIONS, ...NON_ACTION_MIGRATIONS, ...WAIT_DIVERGENCE_MIGRATIONS, ...PLAYBOOK_REFRESH_MIGRATIONS, ...BACKLOG_WRITE_MIGRATIONS, ...WAIT_BUDGET_MIGRATIONS, ...WAIT_SLACK_MIGRATIONS, ...LEARNED_SLACK_MIGRATIONS, ...LOCAL_TICKET_MIGRATIONS, ...ESCALATION_REWAKE_MIGRATIONS, ...HANDOFF_MIGRATIONS, ...REHOME_MARK_MIGRATIONS];

// ---- values kept as JSON ------------------------------------------------------------

Expand Down Expand Up @@ -1838,6 +1867,9 @@ export type WorkerStatus = "running" | "finished" | "failed" | "stopped";
export type WorkerStopReason = "archived" | "stopped" | "runaway" | "deleted" | "misspawn";
export type Worker = { threadId: string; bindingId: string; title: string; status: WorkerStatus; result: string | null; startedAt: number; endedAt: number | null; modelCheckPending: boolean; stopReason: WorkerStopReason | null; /** BB-329: the `waitingOn` the worker's own `worker_park` call recorded, or null when it did not park. Cleared when its next turn starts. */ parkedWaitingOn: string | null };

/** BB-386: a pull request moved from one binding to another; one row per lowercased pull key. */
export type PullHandoff = { pullKey: string; fromBindingId: string | null; toBindingId: string; createdAt: number };

/** The sidebar's ended-list row (BB-294): the columns it renders, never `lastSnapshot`. `url` is added for the board's ended list (BB-295). */
export type EndedBindingRow = { key: string; url: string | null; kind: BindingKind; threadId: string | null; title: string | null; phase: string | null; endReason: string | null; endedAt: number; nonActions: NonActions };

Expand Down Expand Up @@ -2921,6 +2953,46 @@ export function createStore(db: Database.Database, now: () => number, options: S
return confirmed;
}

// BB-386: a pull request moved from one binding to another. One row per
// lowercased pull key; a move overwrites the previous owner. The table may
// be absent on a store the migration tests built from an earlier list, so the
// statements are prepared only when it exists and the methods no-op without
// it (the same shape as the non-actions probe above).
const hasHandoffs = db.prepare("SELECT 1 AS one FROM sqlite_master WHERE type = 'table' AND name = 'pull_handoffs'").get() !== undefined;
const handoffStmts = hasHandoffs
? {
upsert: db.prepare(
"INSERT INTO pull_handoffs (pull_key, from_binding_id, to_binding_id, created_at) VALUES (?, ?, ?, ?) ON CONFLICT(pull_key) DO UPDATE SET from_binding_id = excluded.from_binding_id, to_binding_id = excluded.to_binding_id, created_at = excluded.created_at",
),
get: db.prepare<[string], Record<string, unknown>>("SELECT * FROM pull_handoffs WHERE pull_key = ?"),
all: db.prepare<[], Record<string, unknown>>("SELECT * FROM pull_handoffs"),
}
: null;
const toHandoff = (r: Record<string, unknown>): PullHandoff => ({
pullKey: String(r.pull_key),
fromBindingId: r.from_binding_id === null || r.from_binding_id === undefined ? null : String(r.from_binding_id),
toBindingId: String(r.to_binding_id),
createdAt: Number(r.created_at),
});
// The handoff rows are read on every `pullBelongsToTicket` for a linked pull
// request, so they are cached in memory and the cache is kept in step by the
// two writers. One plugin process owns the table, so a cache entry cannot go
// stale behind it.
const handoffCache = new Map<string, PullHandoff | null>();
// The whole table, read once and kept in step by `handOffPull`, so a binding
// can ask for the pull requests handed to it on every reconcile without a
// query each time.
let handoffToList: Map<string, PullHandoff[]> | null = null;

// BB-386: the re-homing marks. Absent on a legacy store, like the handoffs.
const hasRehomeMarks = db.prepare("SELECT 1 AS one FROM sqlite_master WHERE type = 'table' AND name = 'pull_rehome_marks'").get() !== undefined;
const rehomeMarkStmts = hasRehomeMarks
? {
has: db.prepare<[string, string], { n: number }>("SELECT COUNT(*) AS n FROM pull_rehome_marks WHERE pull_key = ? AND binding_id = ?"),
mark: db.prepare("INSERT INTO pull_rehome_marks (pull_key, binding_id, at) VALUES (?, ?, ?) ON CONFLICT(pull_key, binding_id) DO NOTHING"),
}
: null;

// BB-358: the learned Slack mappings and the DM log. The mapping is keyed by
// the GitHub login or Linear user id; the value is a Slack user id or the
// `not_on_slack` flag. No email is written. The DM log is the per-person,
Expand All @@ -2937,6 +3009,57 @@ export function createStore(db: Database.Database, now: () => number, options: S
const countSlackDm = hasLearnedSlack ? db.prepare<[string, string, number], { n: number }>("SELECT COUNT(*) AS n FROM slack_dms WHERE binding_id = ? AND person_key = ? AND sent_at >= ?") : null;

return {
/**
* BB-386: move a pull request to another binding. `pullKey` is normalised
* to lower case; `fromBindingId` is the binding it leaves, when known.
*/
handOffPull(pullKey: string, toBindingId: string, fromBindingId: string | null): void {
if (handoffStmts === null) return;
const key = pullKey.toLowerCase();
handoffStmts.upsert.run(key, fromBindingId, toBindingId, now());
handoffCache.set(key, { pullKey: key, fromBindingId, toBindingId, createdAt: now() });
handoffToList = null;
projectChanged(projectIdForBinding(toBindingId));
if (fromBindingId !== null) projectChanged(projectIdForBinding(fromBindingId));
},
/** BB-386: the current owner of a handed-off pull request, or null when it was never moved. */
pullHandoff(pullKey: string): PullHandoff | null {
if (handoffStmts === null) return null;
const key = pullKey.toLowerCase();
const cached = handoffCache.get(key);
if (cached !== undefined) return cached;
const r = handoffStmts.get.get(key);
const result = r === undefined ? null : toHandoff(r);
handoffCache.set(key, result);
return result;
},

/** BB-386: the pull requests handed to a binding. */
pullHandoffsTo(bindingId: string): PullHandoff[] {
if (handoffStmts === null) return [];
if (handoffToList === null) {
handoffToList = new Map();
for (const r of handoffStmts.all.all()) {
const h = toHandoff(r);
const list = handoffToList.get(h.toBindingId);
if (list === undefined) handoffToList.set(h.toBindingId, [h]);
else list.push(h);
}
}
return handoffToList.get(bindingId) ?? [];
},

/** BB-386: whether re-homing already handled this pull request for this binding. */
pullRehomeMarked(pullKey: string, bindingId: string): boolean {
if (rehomeMarkStmts === null) return false;
return (rehomeMarkStmts.has.get(pullKey.toLowerCase(), bindingId)?.n ?? 0) > 0;
},
/** BB-386: record that re-homing handled this pull request for this binding. */
markPullRehome(pullKey: string, bindingId: string): void {
if (rehomeMarkStmts === null) return;
rehomeMarkStmts.mark.run(pullKey.toLowerCase(), bindingId, now());
},

/** Run a synchronous handler as one operation, publishing at most one signal per project (BB-90). */
coalescing,
/** Run an async handler as one turn, publishing at most one signal per project (BB-95). */
Expand Down
Loading