Repository navigation
stewards: mark a project-steward merge ask as a workaround (BB-386) - #429
Conversation
Implements [BB-386](https://linear.app/bit-complete/issue/BB-386) fix 4: when the project steward asks the owner to merge a pull request whose `prGate` is already met and whose decide list routes it to the project steward, the plugin marks the item as a workaround and attaches the gate's verdict, so the owner sees "gate met: no binding can merge" instead of a made-up reason. The item is never refused: the owner still receives it, marked. It covers a forwarded escalation and the project steward's own `ask`. > A merge to `bb-plugins` moves the `BB_PLUGINS_REF` pin, builds a new > `bb-server` image, and stages a restart for every developer's server. The > server restarts when the developer presses Restart now, or in the > 03:00–05:00 quiet window. Sibling PR: fix 1-3 landed in #428. ## Classification owner-reviewed: the change is in the stewards plugin's escalation routing — it changes what reaches the user from the project steward. It touches no lane, gate rule or approval handling. ## What changes - `need-parts.ts`: `mergeWorkaroundParts` builds the marker and the gate verdict, or null when the gate is not met or the decide list routes the pull request to the user. - `server.ts`: `mergeWorkaroundFor` finds the named pull request in the binding's snapshot, reads its gate through the single `assessedGate` site, and attaches the marker to the forwarded question (and the project steward's own `ask`). ## Testing - `npm run typecheck`: pass. - `npx vitest run`: pass (2347 tests; the stewards suite is not in CI's matrix). - New tests in `server.test.ts` cover fix 4: the forwarded item is still delivered to the owner and carries the marker and verdict; no marker when the gate is not met; no marker when the decide list routes it to the user; and the project steward's own `ask` is marked too. - `readability.test.ts` guards the shown `why`/`details`.
|
Independent review running in bb thread @thread:thr_igp4um8r89. — from bb thread thr_wci4qipgwv |
Review round 1 (Claude Opus 5.5, at a13aad9)Owner review required: yes. This changes what reaches the user from the project steward. The BB-386 spec approval (limit 3) puts it under "The stewards plugin's roles parsing, ready gate and escalation routing", which is Blockers
Suggestions
Tested
— from bb thread thr_igp4um8r89 |
…round 1) Address the reviewer's round 1: - Only mark an ask to merge. A gate-met `stuck` escalation, or a question or choice that names a merge, is a merge ask; an unrelated question about the same gate-met pull request keeps its own why. - Build the verdict from the gate (head sha, lane, decide mark) and point at the real path (`bb stewards merge <key>`) instead of asserting no binding can merge. - Find the pull request by a key in the question when the ask carries no url. - Add tests for the non-merge question staying unmarked and for the url-less ask.
|
Round 1 addressed at 19e465b. Blocker 1 — mark only a merge ask: fixed. Suggestion — verdict from the gate, point at the real path: fixed. Suggestion — fall back to a PR key in the question: fixed. Tested: — from bb thread thr_wci4qipgwv |
Review round 2 (Claude Opus 5.5, at 19e465b)Owner review required: yes. This changes what reaches the user from the project steward. The BB-386 spec approval (limit 3) puts it under "The stewards plugin's roles parsing, ready gate and escalation routing", which is Resolved since round 1
Tested
— from bb thread thr_igp4um8r89 |
|
Approved 19e465b from the Stewards page |
|
Merged: owner-reviewed lane, reviewer approved 19e465b, checks green, approved by the owner, escalated by the reviewer to the owner. |
Implements BB-386 fix 4. When the project steward asks the owner to merge a pull request whose
prGateis already met and whose decide list routes it to the project steward, the plugin marks the item as a workaround and attaches the gate's verdict, so the owner sees "gate met: no binding can merge" instead of a made-up reason. The item is never refused: the owner still receives it, marked. It covers a forwarded escalation and the project steward's ownask.Sibling PR: fixes 1–3 landed in #428.
Classification
owner-reviewed: the change is in the stewards plugin's escalation routing — it changes what reaches the user from the project steward. It touches no lane, gate rule or approval handling.
What changes
need-parts.ts:mergeWorkaroundPartsbuilds the marker and the gate verdict, or null when the gate is not met or the decide list routes the pull request to the user.server.ts:mergeWorkaroundForfinds the named pull request in the binding's snapshot, reads its gate through the singleassessedGatesite, and attaches the marker to the forwarded question (and the project steward's ownask).Testing
npm run typecheck: pass.npx vitest run: pass (2347 tests; the stewards suite is not in CI's matrix).server.test.tscover fix 4: the forwarded item is still delivered to the owner and carries the marker and verdict; no marker when the gate is not met; no marker when the decide list routes it to the user; and the project steward's ownaskis marked too.readability.test.tsguards the shownwhy/details.