chore(deps): bump browserslist to 4.28.9 to fix high severity audit - #382
Open
aharoitx wants to merge 1 commit into
Open
chore(deps): bump browserslist to 4.28.9 to fix high severity audit#382aharoitx wants to merge 1 commit into
aharoitx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
auditjob fails on every open PR. It is not caused by any of them:running
npm audit --audit-level=highon a clean8.0.xexits with code 1.browserslist@4.28.1has two high severity advisories:Both are fixed in 4.28.7+.
Fix
npm update browserslist --package-lock-only→ 4.28.9.Only
package-lock.jsonchanges (27 insertions, 42 deletions).browserslistisa transitive dev dependency (via
@babel/helper-compilation-targets,core-js-compatand
update-browserslist-db), requested with a^4.xrange — refreshing the lockfileis enough. No override needed,
package.jsonuntouched.Verification
Before:
3 vulnerabilities (1 low, 1 moderate, 1 high)→ exit 1After:
2 vulnerabilities (1 low, 1 moderate)→ exit 0The two remaining ones do not block at
--audit-level=high:elliptic(low, prod, no upstream fix available)@humanfs/node(moderate, dev) — resolved by chore(deps-dev): bump @humanfs/node from 0.16.7 to 0.16.8 in the npm_and_yarn group across 1 directory #381Locally:
build,format:ci,lintandunitall pass.