Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The star layers use the wrong rotation reference and move in the wrong direction during panning.
2 open findings
What changed in this PR
This PR adds background-star movement during galaxy navigation to address issue #1.
Changes:
- Adds two star layers with different parallax rates.
- Updates their transforms before each frame is rendered.
| File | Description |
|---|---|
web/script.js |
Adds and animates parallax transforms for the background stars. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| makeStarLayer(2500, 1.5, 0.3) | ||
|
|
||
| function updateStarLayers() { | ||
| starInverseQuat.copy(camQuat).invert() |
| function updateStarLayers() { | ||
| starInverseQuat.copy(camQuat).invert() | ||
| starLayers.forEach(({ points, parallax }) => { | ||
| starOffset.copy(camTarget).multiplyScalar(parallax) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1