Repository navigation
Support overall times in stage lifecycle messages - #78
Merged
Merged
Conversation
Updates stage start and end messages to optionally send an overall time if it is known. Adds overall time tracking to the base challenge class, defaulting to empty, for individual challenges to override if they support it. Overall times can either be server-authoritative or a local counter (like in Inferno). Adds TFA overall time tracking by reading the game script that updates the raid timer widget and comparing against chat messages when they are sent.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🟩 Auto-review token estimate: ~132,890 / 200,000 (66%)🔺 +1,093 tokens vs base (was ~131,797)
|
frolv
added a commit
that referenced
this pull request
Oct 26, 2026
Updates stage start and end messages to optionally send an overall time if it is known. Adds overall time tracking to the base challenge class, defaulting to empty, for individual challenges to override if they support it. Overall times can either be server-authoritative or a local counter (like in Inferno). Adds TFA overall time tracking by reading the game script that updates the raid timer widget and comparing against chat messages when they are sent. (cherry picked from commit 91d377f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates stage start and end messages to optionally send an overall time if it is known. Adds overall time tracking to the base challenge class, defaulting to empty, for individual challenges to override if they support it. Overall times can either be server-authoritative or a local counter (like in Inferno).
Adds TFA overall time tracking by reading the game script that updates the raid timer widget and comparing against chat messages when they are sent.