Repository navigation
Make mokhaiotl a generic NPC - #86
Conversation
Updates the Mokhaiotl tracker to remove most of its bespoke events and its attacks, keeping only larva leaks as that requires hitsplat information.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🟩 Auto-review token estimate: ~131,808 / 200,000 (66%)🔻 -3,519 tokens vs base (was ~135,327)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10b540cf83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!ignoreCooldown) { | ||
| offCooldownTick = tick + attack.getCooldown(); | ||
| } | ||
| offCooldownTick = tick + attack.getCooldown(); |
There was a problem hiding this comment.
When a player blowpipes a larva or volatile earth and switches weapons to attack on the following tick, unconditionally advancing offCooldownTick prevents Raider.updateState() from detecting STOPPED_PIPING until the normal two-tick blowpipe cooldown expires. If the lingering blowpipe animation suppresses the new weapon's animation—the case explicitly handled in DataTracker.checkForPlayerAttack()—the follow-up attack is now missed or recorded late. These targets previously bypassed the cooldown update through npcIgnoresCooldown; converting their NPC recording to generic events should preserve that player-attack tracking behavior.
Useful? React with 👍 / 👎.
Updates the Mokhaiotl tracker to remove most of its bespoke events and its attacks, keeping only larva leaks as that requires hitsplat information. (cherry picked from commit 1732ace)
Updates the Mokhaiotl tracker to remove most of its bespoke events and its attacks, keeping only larva leaks as that requires hitsplat information.