Repository navigation
Conversation
Collaborator
|
Did you use AI to generate this PR? Have you manually reviewed it? Could you please fill out the PR template? |
Collaborator
|
Closed due to no response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
N/A — this is a localization contribution and is not associated with an existing issue.
Summary of the issue:
Bookworm already has Hungarian application localization and a Hungarian user guide, but the Windows NSIS installer did not have a complete, reviewed Hungarian localization.
The stock Hungarian NSIS files also contain spelling errors, awkward or outdated wording, partially untranslated text, and a mnemonic collision.
Description of how this pull request fixes the issue:
This pull request adds reviewed Hungarian localization for the Windows installer.
It adds custom Hungarian NSIS Modern UI and core language files and integrates them through MUI_LANGUAGEEX.
It also localizes Bookworm-specific installer text, the language-selection dialog, shortcut names, the Hungarian user-guide shortcut, upgrade messages, and uninstall-related text.
The selected installer language is remembered and reused by the uninstaller.
The existing Publisher registry value is also corrected so it is written under Bookworm's own uninstall registry key.
AI was used as an assistance tool during preparation of parts of the NSIS integration, code review, and static checks. The Hungarian wording was manually reviewed, and the generated installer was manually tested rather than submitting AI-assisted output without review.
Testing performed:
Static checks of all Hungarian NSIS language entries.
Encoding, structure, registry logic, shortcut-path, and mnemonic checks.
GitHub Actions tests passed.
x86 build and installer generation passed.
x64 build and installer generation passed.
The generated x64 installer was manually tested on Windows with a screen reader.
That manual test identified an encoding issue in the initial Hungarian language-selection prompt.
The encoding was corrected and the updated x86 and x64 CI builds passed successfully.
The corrected x64 installer has not yet been manually re-tested.
Known issues with pull request:
No known installer-localization issues at this time.
The full GNU GPL license text intentionally remains the upstream English LICENSE file.
The corrected x64 installer and the x86 installer have passed CI but have not yet been manually exercised.