Repository navigation
Replace deprecated parse_obj with model_validate in json_resource - #428
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
In bookworm/http_tools/json_resource.py, replace BaseModel.parse_obj with model_validate to conform with Pydantic v2 and prevent PydanticDeprecatedSince20 warnings. Add unit tests for RemoteJsonResource covering successful validation, deprecation warning suppression, error handling, and request retrieval. Fixes blindpandas#422.
Author
|
Closing in favor of earlier community PR #423 to avoid duplicate review effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #422.
This PR replaces self.model.parse_obj(data) with self.model.model_validate(data) in bookworm/http_tools/json_resource.py.
Background and Rationale
In Pydantic v2 (pinned at >=2.4.0 in pyproject.toml), BaseModel.parse_obj() is deprecated and emits a PydanticDeprecatedSince20 warning on every call. model_validate() is the recommended method with identical semantics for validating input data against a Pydantic model.
Changes
Verification