Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Blip reports table I/O by table and query counters at server scope. Operators who share one MySQL server cannot compare statement load and table activity by schema without building their own rollups.
What
Add an opt-in
stmt.schemadomain for statement counts, latency, errors, and row activity grouped bydb.Add
group-by: table|schema|bothtowait.io.table; the current table output remains the default.How
The new collector sums selected counters from
events_statements_summary_by_digestbySCHEMA_NAME. The I/O collector rolls up table handler counts and wait times by owning schema. It weights averages by event count and excludes empty tables from minimum wait times. Schema sums scan asfloat64because MySQL can return values aboveMaxInt64.Risk
Both modes are opt-in. Schema statement series omit null-schema and digest catch-all rows, so they can undercount when the digest table fills.
group-by: bothreads the table I/O summary twice per collection.Testing
Started the repository's MySQL 8.0.34 Compose service and ran
go test -count=1 ./...; all packages passed. The integration tests exercised both collectors, and a regression test passed with a schema sum aboveMaxInt64. The service was torn down after testing.Generated with Codex