Skip to content

fix(payments): step-back nav and mismatched flow copy in US-bank step… - #60

Merged
MakelangelOO merged 1 commit into
mainfrom
develop
Sep 9, 2026
Merged

MakelangelOO merged 1 commit into
mainfrom
develop

Conversation

@MakelangelOO

Copy link
Copy Markdown
Collaborator

…s (#59)

  • fix(payments): step-back navigation and mismatched flow copy in US-bank steps
  • UsAmountStep had no back button, trapping users on that step
  • topup/send us-banks flows showed a generic account error even when the real cause was a rejected KYC
  • TopUpConfirmStep/TopUpAmountStep (used only by send/colombian-banks) leaked topup/PSE-specific copy (title, PSE disclaimer, PSE fee label) into the send flow
  • feat(accounts): allow creating a pocket account anchored to an existing ledger
  • CreateVirtualAccountInput/createVirtualAccount now pass ledgerId through to the SDK, matching card/polygon — needed to attach a pocket to an account whose ledger already exists but has no pocket product yet (see BQE-2653: external-us-bank accounts stuck with no destination pocket)
  • account detail's "add product" now offers a pocket/"Cuenta" option alongside card/breb/polygon, wired the same way (ledgerId: account.ledgerId)
  • home quick actions (topup/send/BRE-B) are disabled with a toast hint when the user has no account yet, instead of failing deep inside each flow with a confusing "no destination account" error
  • the "+ new account" card is visually highlighted (primary border, underlined label) when the user has zero accounts
  • fix(home): don't treat a still-loading accounts query as "no accounts"

hasAccount and the carousel's highlight both read accounts.length off the query's data, which is [] before it resolves too — that flashed the quick actions as disabled (with the "create an account" toast) and highlighted the add-account card for users who do have one, on first login/cold cache.


#59)

* fix(payments): step-back navigation and mismatched flow copy in US-bank steps

- UsAmountStep had no back button, trapping users on that step
- topup/send us-banks flows showed a generic account error even when the
  real cause was a rejected KYC
- TopUpConfirmStep/TopUpAmountStep (used only by send/colombian-banks)
  leaked topup/PSE-specific copy (title, PSE disclaimer, PSE fee label)
  into the send flow

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* feat(accounts): allow creating a pocket account anchored to an existing ledger

- CreateVirtualAccountInput/createVirtualAccount now pass ledgerId through
  to the SDK, matching card/polygon — needed to attach a pocket to an
  account whose ledger already exists but has no pocket product yet
  (see BQE-2653: external-us-bank accounts stuck with no destination pocket)
- account detail's "add product" now offers a pocket/"Cuenta" option
  alongside card/breb/polygon, wired the same way (ledgerId: account.ledgerId)
- home quick actions (topup/send/BRE-B) are disabled with a toast hint
  when the user has no account yet, instead of failing deep inside each
  flow with a confusing "no destination account" error
- the "+ new account" card is visually highlighted (primary border,
  underlined label) when the user has zero accounts

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(home): don't treat a still-loading accounts query as "no accounts"

hasAccount and the carousel's highlight both read accounts.length off the
query's data, which is [] before it resolves too — that flashed the quick
actions as disabled (with the "create an account" toast) and highlighted
the add-account card for users who do have one, on first login/cold cache.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@MakelangelOO
MakelangelOO merged commit 158820a into main Sep 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant