Repository navigation
Modernize devcontainer: Dockerfile-only build with mise-managed tools - #39
Merged
Merged
Conversation
Replace every devcontainer feature with plain Dockerfile layers and move all versioned tools into .devcontainer/mise.toml, installed system-wide with mise. A feature-free image is what lets Coder's envbuilder cache probe match the prebuilt image and boot workspaces without rebuilding (see PR #32). - Base image: typescript-node 26-trixie (Node 26 LTS, Debian 13). - mise.toml pins Go 1.27.3, Ruby 4.0.9, Rust 1.99.1, kubectl/helm/minikube, gh, az, golangci-lint/staticcheck/gopls/dlv/govulncheck, Claude Code, Copilot CLI, opencode, pi, and tmux 3.7c (official static build). - Shims dir, GOPATH, CARGO_HOME, RUSTUP_HOME are system-wide and node-owned so tools work in non-interactive shells and survive a persisted home. - sshd (2222) and /workspaces ownership handled in the Dockerfile (from #30). - Drop @openprose/prose-cli (no longer needed) and devcontainer-lock.json. - tmux.conf: tmux-256color, allow-passthrough (all on 3.4+), focus-events, extended-keys, set-clipboard, escape-time 10, bigger history. Key bindings unchanged. Fixes Claude Code notifications/Shift+Enter/Esc inside tmux. - New weekly "Bump mise tools" workflow (mise upgrade --bump) replaces the Dependabot devcontainers ecosystem; actions/checkout bumped to v7. - verify-devcontainer.sh also checks /workspaces is writable and that every mise tool is installed and runnable via shims. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AihTX41wWUjfBk3c2A9h2Z
kaniko (envbuilder) denies the non-root user write access to /dev/stderr, so the build failed after a fully successful mise install. Use a plain shell test instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AihTX41wWUjfBk3c2A9h2Z
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AihTX41wWUjfBk3c2A9h2Z
This was referenced Oct 30, 2026
go, kubectl, helm, tmux and gopls do not accept --version, which made the new shim check report false failures on an otherwise good build. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AihTX41wWUjfBk3c2A9h2Z
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AihTX41wWUjfBk3c2A9h2Z
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AihTX41wWUjfBk3c2A9h2Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two things at once: bring every dependency up to date, and make the image reproducible by envbuilder's cache probe. Devcontainer features can't be reproduced by the probe (coder/terraform-provider-envbuilder#68, as researched in #32), so this removes all of them and installs everything from the Dockerfile, with versions centralised in
.devcontainer/mise.toml.What changed
typescript-node:26-trixie(Node 26 LTS, Debian 13).ghcr.io/jdx/mise:2026.10.23) installs every versioned tool system-wide frommise.toml→/etc/mise/config.toml; shims are onPATHfor all shells, nomise activateneeded. Go 1.27.3, Ruby 4.0.9, Rust 1.99.1, kubectl 1.37.2, helm 4.3.1, minikube, gh, az, golangci-lint, staticcheck, gopls, dlv, govulncheck, Claude Code, Copilot CLI, opencode, pi, tmux 3.7c.postStartCommand), nsc, Playwright, tmux config, and chowns/workspacestonode(from Fix /workspaces permissions so the node user can clone repos #30).tmux-256color,allow-passthrough(allon 3.4+),focus-events,extended-keys,set-clipboard,escape-time 10, 50k history. This is what makes Claude Code notifications, the progress bar, Shift+Enter and Esc work inside tmux under iTerm2.Bump mise toolsworkflow (mise upgrade --bump→ PR) replaces Dependabot's devcontainers ecosystem;actions/checkout→ v7 (supersedes Bump actions/checkout from 6 to 7 #27).@openprose/prose-cli,devcontainer-lock.json, all features./workspacesis writable and every mise tool is installed and runs via shim.Validation
mise installof this exactmise.tomlwas exercised in the current container (all tools resolve and run; rust needs the writable homes the Dockerfile now creates).Supersedes #32, #30, #27, #34, #35, #37.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AihTX41wWUjfBk3c2A9h2Z