Bump version to 0.3.3 - #18
Merged
Merged
Conversation
…umns _insert_test_data used cur.executemany() for every row regardless of table shape, which sends one parse/bind/execute round trip per row. Benchmarked against OneSales' real fixtures (87k rows across 46 tables, 91% of rows on plain-scalar tables with no composite/enum/jsonb columns): seeding end-to-end dropped from ~17.4s to ~12.5s per ensure_testdb(force_reset=True) call, and _insert_test_data's own cumulative time from ~25s to ~15s in a cProfile comparison. Tables with any composite/enum/jsonb column keep the existing recursive_convert + executemany path untouched (that logic is unaffected and still exercised by test_apply_schema_seeds_composite_enum_and_jsonb_columns). Verified: pgdevkit's own test_schema.py suite (7/7 passing, including the composite/enum/jsonb case), row counts matching fixture counts exactly on the COPY path, and OneSales' full unit suite (1794/1798 passing, same 4 pre-existing unrelated failures with and without this change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.