CHANGELOG: the partition limit that D15 removed and the one it left - #28
Merged
Conversation
The "Only the first partition of an AKAI disc is read" entry under Unreleased / Known limits contradicted the Added bullet in the same section: PR #26 read every partition from the table at 0x4500 and closed issue #22, and this entry should have gone with it. Its own explanation was also superseded — partitions come from the table, not from tiling at multiples of the size at 0x00, and their sizes are not all equal (ADR-0023). What survives is the narrower limit ADR-0023 states plainly: a declared partition with no header at its declared position is skipped rather than searched for, leaving roughly fifteen thousand readable files unread on the nine short images, which is issue #25. That is what the bullet now says. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The
## Unreleasedsection contradicted itself about AKAI partitions. Under Added:and forty lines below, under Known limits:
The second is stale. #26 / D15 read every partition from the table the disk declares at
0x4500and closed #22; the Known limits entry should have been removed in that PR and was not. Confirmed against ADR-0023 andpartitions()in src/samplerdisc/fs/akai.py:211, which walks every declared partition and yields each one the image confirms a header at.Its explanation was superseded as well, not just its headline. The bullet described partitions as laid "end to end at multiples of the size declared at
0x00" — the observation from the issue, which ADR-0023 measured and rejected. The sizes are not all equal: the last partition is a remainder, and tiling invents a fourteenth partition onAKAI.S3000.Sound.Library.1that the disk does not declare. Leaving that sentence in as history would have left a wrong statement about the format in the file a reader checks first.What survives
One part of the old bullet is still true, and it is the part ADR-0023 states plainly under "Bad, and stated plainly": a declared partition with no header at its declared position is skipped, never searched for. So the entry is rewritten to that, rather than deleted:
Every figure in it comes from a measurement already in the repo: the displacement table in docs/formats/akai-fs.md has the nine discs and both endpoints, and the fifteen thousand is ADR-0023's own count for what scanning for headers would recover. The bullet sits directly after the
Kickin' Lunatic Beats 2 CD1entry, whose nine wrong files it points back at — the two limits are the same fault seen from outside and inside partition 1 — and it carries #25, which was open with nothing in the changelog pointing at it.What this does not claim
No behaviour changes and no code is touched. This is the changelog catching up with what shipped; nothing here re-opens whether skipping a displaced partition is the right call. #25 stays open and stays the place that work is recorded.
Verification
The 56 skips are the real-disc tests, which skip with
SAMPLERDISC_TEST_DISCSunset (ADR-0008).🤖 Generated with Claude Code