Repository navigation
Allow empty pytest collection in CI test workflow - #6
Merged
Merged
Conversation
Co-authored-by: bobby404-K <191977924+bobby404-K@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job test
Allow empty pytest collection in CI test workflow
Sep 11, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped and preserves real test failures.
Pull request overview
Updates the CI test workflow so an empty pytest collection does not fail the job.
Changes:
- Accepts pytest exit code
5. - Preserves failures for other non-zero exits.
File summaries
| File | Description |
|---|---|
.github/workflows/tests.yml |
Adjusts pytest exit-code handling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testGitHub Actions job was failing even when repository state was valid becausepytestexits with code5when no tests are collected. This change updates the workflow to treat that specific exit code as non-failing so the job can proceed to notebook execution.Root cause
pytestin.github/workflows/tests.ymlfailed the job on exit code5(collected 0 items), which is not a test failure.Workflow change
5while preserving failure behavior for all other non-zero exits.Resulting behavior