Keep a decimal point when the sentence ends with a period - #222
Merged
Merged
Conversation
preserve() searched for the matched punctuation text, so a final period also split 3.14.
Collaborator
|
Thanks for your PR. Please update the CHANGELOG as well, and if the tests pass I'll merge it. |
The maintainer asked for a changelog entry before merge.
Contributor
Author
|
Thanks for the note. The changelog now has an unreleased bugfix entry for this. |
Collaborator
|
thanks! |
Contributor
Author
|
Thanks for merging this. |
SashaMIT
added a commit
to SashaMIT/oss-contributions
that referenced
this pull request
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preserveof3.14 is pi.came back as3.and14 is pi..1.5.came back as1.and5.. The matcher already skips a period that sits between digits, but the cut searched for that period again, so the sentence-final period also split the number.see 3.14!stayed one chunk, because that mark is not a period.19,99 eurostill stays together.The new cases are in
test_decimal_separator_preserve_restore.