Repository navigation
Coders and testers only hear the repo's people on GitHub, not strangers' comments (0.21.1) - #1
Merged
Conversation
…rs' comments (0.21.1) On a public repo anyone can comment on the Overlord's own issues and pull requests. A coder's prompt now carries the issue's comments from the owner, org members and collaborators (the newest five, each cut at 1,500 characters; nothing when there are none), and a tester's prompt carries the linked issue's. Both are told that anything else on GitHub is untrusted data and not to read comments themselves. issueDetails fetches comments with their authorAssociation; the filter is trustedComments in server/trust.ts. This is an instruction, not a lock: CLAUDE.md keeps tool calls unblocked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 0.21.0, which stopped the dungeon taking work from strangers. On a public repo anyone can still comment on the Overlord's own issues and pull requests, and coders and testers can read those comments with
ghor a browser.What changes
issueDetailsnow fetchescommentswith each author'sauthorAssociation. The filter istrustedCommentsinserver/trust.ts, with tests next to it.The DungeonMaster needed no change. It can't run shell commands, and it sees GitHub only through the dungeon's status, which already leaves strangers out.
This is an instruction, not a lock
CLAUDE.md says not to add hooks, permission rules or sandboxes that refuse tool calls. So a coder or tester can still choose to read a stranger's comment. This change gives them no reason to, and tells them to treat it as data if they do.
How it was verified
npm run typecheck,npm test(89 files, 952 tests),npm run buildandnpm run test:e2e(18 passed) all pass locally.gh issue view(no TTY) prints the body and a comment count, not the comments.--json commentsgives each comment'sauthorAssociation.MEMBER) and dropped a bot's (NONE). On #14715, all seven bot comments were dropped and the prompt was unchanged.SWARM_HOME:Assumptions
🤖 Generated with Claude Code