Skip to content

Avoid exporting empty coding-agent session roots - #93

Merged
Stephen Belanger (Qard) merged 1 commit into
mainfrom
fix/sdk-375-lazy-roots
Sep 22, 2026
Merged

Stephen Belanger (Qard) merged 1 commit into
mainfrom
fix/sdk-375-lazy-roots

Conversation

@Qard

Copy link
Copy Markdown
Collaborator

Defer Codex, OpenCode, Pi, and Antigravity session roots until a child work span arrives. Lifecycle-only sessions are discarded during sink flush, preventing empty traces and Topics processing.

The gate is shared in the Braintrust sink and strips its internal marker before delivery.

Validation: cargo test --locked --manifest-path bt-daemon/Cargo.toml --all-features.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-22T17:05:30.140170Z 2a63ea1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a63ea1650

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread bt-daemon/src/sink/braintrust.rs Outdated
Comment thread bt-daemon/src/sink/braintrust.rs Outdated
@Qard
Stephen Belanger (Qard) merged commit 1e5b05b into main Sep 22, 2026
20 checks passed
@Qard
Stephen Belanger (Qard) deleted the fix/sdk-375-lazy-roots branch September 22, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants