Conversation
breuner
reviewed
Aug 18, 2025
shustinm
force-pushed
the
s3-cors-handler
branch
4 times, most recently
from
August 18, 2025 18:08
ab96537 to
6b7ea7f
Compare
shustinm
force-pushed
the
s3-cors-handler
branch
from
August 20, 2025 13:51
6b7ea7f to
a794337
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for S3 CORS.
elbencho will not configure the bucket cors, and will only send an
Originheader, and expects anAccess-Control-Allow-Originheader back (with the same value or*).Due to current limitations of the implementation, elbencho doesn't validate the response header in
PUTorDELTErequests, onlyGETrequests. This is due to a limitation of the current implementation which usesSetHeadersReceivedEventHandler.This is why
GETfunctions uses3ModeAddCorsHeaderands3ModeThrowOnCorsError, whilePUTandDELETEfunctions just set the header (invokeSetAdditionalCustomHeaderValuedirectly)