feat(create): add --disk-size flag - #439
Open
theFong wants to merge 2 commits into
Open
Conversation
…-size # Conflicts: # pkg/cmd/gpucreate/gpucreate.go
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 24.67% 26.07% +1.40%
==========================================
Files 134 135 +1
Lines 18337 18620 +283
==========================================
+ Hits 4525 4856 +331
+ Misses 13335 13259 -76
- Partials 477 505 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
theFong
marked this pull request as ready for review
August 22, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--disk-size <GB>flag tobrev createWhy
The create API already accepts
diskStorage, and search/piped workflows already populateInstanceSpec.DiskGB. However, explicitly selected instance types were created withDiskGB: 0, so agents and users had no direct way to request variable storage while using--type.Impact
Agents can now deploy a GPU with provider-supported variable storage directly:
The value is sent to the create API as a Gi quantity. Provider-side storage constraints continue to determine which sizes are supported.
Validation
go build ./...go test ./pkg/cmd/gpucreatego test -race ./pkg/cmd/gpucreatego vet ./pkg/cmd/gpucreategolangci-lint run ./pkg/cmd/gpucreateCloses #380.