Repository navigation
Add the Greek forefeast labels and Greek-dated commemorations - #256
Merged
Merged
Conversation
The rest of issue #228's headline differences: - Leavetaking of the Nativity of the Forerunner (Jun 25) - Protection of the Theotokos on its Greek date (Oct 28) - Forefeast of the Conception (Dec 8) - Forefeast of Nativity (Dec 21-23) - Hieromartyr Phocas on Jul 23, linked to his existing Saint Each matches antiochian.org in every or nearly every harvested year. A feast name can't be set by an override row, so each common row is split into a slavic row and an identical greek copy that adds the name, as Oct 1 already is. Fasting, rank and saints are unchanged, and Slavic output is identical. Dec 26, Jan 8-13 and Feb 3 are left alone; see docs/greek-commons.md, pass 13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second half of the remaining title differences from #228 (the first is #255). The two PRs are independent and can merge in either order.
Added for Greek
How
Day.OVERRIDABLE). Eachcommonrow (612, 737, 778, 791-793) becomesslavic, with an identicalgreekcopy (950-955) that adds the name. Oct 1's Protection already has this shape.greekcommemoration on Jul 23, linked to his existing Saint. He keeps Sep 22 in both traditions, as antiochian.org lists him on both dates.Unchanged
Deliberately left alone
summary_titleand move us away from goarch.org.Both are documented in
docs/greek-commons.md, pass 13.Tests
New
test_greek_only_feast_labelsandtest_phocas_on_july_23_for_greek. The full suite passes locally except the knownMonthCacheTestCasefailure (localDummyCache).🤖 Generated with Claude Code