Repository navigation
Migrate fee retrieval off deprecated Kraken AssetPairs.fees_maker - #130
Merged
Merged
Conversation
Documentation build overview
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
- Coverage 83.67% 83.61% -0.06%
==========================================
Files 25 25
Lines 1678 1691 +13
==========================================
+ Hits 1404 1414 +10
- Misses 274 277 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tKraken deprecated
fees/fees_makeronAssetPairs(always[]as of 2026-09-08, https://docs.kraken.com/exchange/changelog), which crashed__retrieve_asset_informationwith anIndexErrorwhenever--feewasn't passed explicitly.This PR changes how the fee is estimated by using python-kraken-sdk v3.4.0 that introduces support for the new way of determining the fee schedule
Related changes:
The integration tests were running against the live Kraken API, causing the changed behavior now.
The AAPLxUSD volume values needed to be changed. Back then, the fee was -0.02% (https://www.kraken.com/features/fee-schedule). Now this is set to the same value as for the other tests to keep it uniform and deterministic.
Closes #127
Closes #128
Closes #129