Skip to content

Fix get_trade_volume crash on list-of-object pair values - #466

Merged
btschwertfeger merged 2 commits into
masterfrom
fix-get-trade-volume-pair-objects
Sep 27, 2026
Merged

btschwertfeger merged 2 commits into
masterfrom
fix-get-trade-volume-pair-objects

Conversation

@btschwertfeger

Copy link
Copy Markdown
Owner

Kraken's GetTradeVolume endpoint accepts pair as a list of {asset, aclass} objects for non-forex classes, as documented at https://docs.kraken.com/api/docs/rest-api/get-trade-volume.

@btschwertfeger btschwertfeger added Bug Something isn't working Spot Topic related to Spot trading labels Sep 27, 2026
@btschwertfeger btschwertfeger self-assigned this Sep 27, 2026
@btschwertfeger btschwertfeger added this to the Upcoming Release milestone Sep 27, 2026
@btschwertfeger
btschwertfeger enabled auto-merge (squash) September 27, 2026 15:18
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.55%. Comparing base (3c69476) to head (5d2811c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/kraken/spot/user.py 71.42% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   84.37%   84.55%   +0.17%     
==========================================
  Files          23       23              
  Lines        2022     2026       +4     
==========================================
+ Hits         1706     1713       +7     
+ Misses        316      313       -3     
Flag Coverage Δ
futures-private 51.87% <14.28%> (-0.16%) ⬇️
futures-public 51.77% <14.28%> (-0.16%) ⬇️
spot-private 60.51% <71.42%> (+0.27%) ⬆️
spot-public 58.48% <28.57%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/kraken/spot/user.py 96.15% <71.42%> (-1.47%) ⬇️

... and 2 files with indirect coverage changes

@btschwertfeger
btschwertfeger merged commit 592b217 into master Sep 27, 2026
57 of 58 checks passed
@btschwertfeger
btschwertfeger deleted the fix-get-trade-volume-pair-objects branch September 27, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Spot Topic related to Spot trading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant