Repository navigation
Clear the SwiftLint warnings - #34
Merged
Merged
Conversation
Drop redundant `= nil` initializers, needless parentheses and a trailing `break`, use `+=`, `contains` and failable string initializers, and find the first differing byte without `enumerated()`. D88Disk keeps its lossy UTF-8 fallback for disk names on purpose, with the rule silenced there. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/lint.sh（bubio/Bubilator88 側）で出ていたコアの SwiftLint 指摘 16 件を解消= nil、guardの不要な括弧、default末尾の不要なbreakを削除ssgPhase += 1、reduce(into: false)→containsString(decoding:)→ failableString(bytes:encoding:)（MemoryImage は ASCII 限定、CApiTests は元々String?）enumerated()を使わず最初の差分インデックスを取得（unused_enumeratedの誤検知回避）swiftlint:disable:thisに理由を添えて残すアプリ側の対応する変更は bubio/Bubilator88 の lint 修正 PR。
Test plan
swift test（1046 tests passed）scripts/regression_compare.py（20/20 PASS）scripts/lint.shで指摘 0 件scripts/format_all.sh --checkOK🤖 Generated with Claude Code