Repository navigation
Invert the block cursor cell in B/W graphics - #37
Merged
Merged
Conversation
The CRTC applies the block cursor as a reverse attribute, and B/W attribute graphics take their reverse from the attributes, but the cursor only reached the text overlay. N88-日本語BASIC draws its text into graphics over blank text VRAM, so its cursor never showed. Fold the visible block cursor into the attributes the graphics renderer reads, as BubiC does with its shared attrib.expand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attrib.expandに XOR しているのと同じ）PC88.glyphのコメントを修正：FONT.ROM が無くても全部 0 にはならず、内蔵フォントが 0x00〜0xF7 を描く（0xF8〜0xFF は実 ROM と同じく空白）Test plan
swift test全 1054 件成功（新規attributeGraphAttributesInvertBlockCursorCellを含む）scripts/regression_compare.py20/20 PASS🤖 Generated with Claude Code