Exercise the bktec OTLP relay in the RSpec example - #63
Conversation
There was a problem hiding this comment.
Because this switches the example onto a per-run relay credential, it sits above this repository's AI approval ceiling. I didn't find an implementation issue in the change.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 20304, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
Amp-Thread-ID: https://ampcode.com/threads/T-01a032af-a1ec-7260-9a55-326feca62b28 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a032af-a1ec-7260-9a55-326feca62b28 Co-authored-by: Amp <amp@ampcode.com>
Pin the relay release candidate and current bktest main so the Ruby collector can consume bktec's standard OTLP exporter headers without a relay-specific token configuration. Amp-Thread-ID: https://ampcode.com/threads/T-01a032af-a1ec-7260-9a55-326feca62b28 Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
This still routes the RSpec example through bktec's per-run local relay credential, so the runtime and authentication change remains above this repository's AI approval ceiling. I didn't find an implementation issue in the current revision.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 20844, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
|
@buildsworth-bk review approve L2 |
|
I'll leave this as draft for now, until we have proper bktec and test-collector-ruby releases to use. |
Amp-Thread-ID: https://ampcode.com/threads/T-01a032af-a1ec-7260-9a55-326feca62b28 Co-authored-by: Amp <amp@ampcode.com>
|
Rebased against the latest This now uses the released Verification:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The RSpec example should exercise the same OTLP-only path customers can use with bktec, rather than sending execution spans directly from the test process to Buildkite.
Changes
tests#v1.0.1andbktec v3.1.0-rc.1, which contains the experimental relayBUILDKITE_TESTS_OTLP_RELAYfor the RSpec pipeline stepOTEL_EXPORTER_OTLP_TRACES_*environment instead of configuring a relay-specific token inspec_helper.rbContext
Testing
.buildkite/pipeline.ymlbundle checkspec/models/user_spec.rbagainst a local fake OTLP endpoint; two requests arrived with the standard Bearer header overriding a different collector token, plus thebuildkite.otlp.endpointresource attributeRollback
Remove
BUILDKITE_TESTS_OTLP_RELAY, the client pin, and the released collector dependency changes.