Repository navigation
Stop naming a meta method that no longer exists - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to webgestalt_rust#36, which removes
MetaAnalysisMethod::Fisher— its implementation returned a chi-square density rather than a p-value (#30).Merge this first. It drops the package's dependency on that variant, so the next re-vendor after #36 lands compiles cleanly.
No behaviour change
multiOraEnrichment.Rpassed"fisher"torust_multiomics_ora, and then discarded the meta-p it got back and recomputed it withpoolr::stouffera few lines later.multiswGsea.Rdoes the same for GSEA. So the Fisher path ran on every multi-omics ORA analysis and its output never reached a user — no published result is affected.It now asks for
"stouffer", which is what the R layer was doing anyway.Changes
src/rust/src/lib.rs— bothrust_multiomics_oraandrust_multiomics_gseaselected Fisher on the string"fisher"and Stouffer on anything else; both now select Stouffer unconditionally. The second site is easy to miss: it sits inside thecombo_method == "meta"branch.R/multiOraEnrichment.R— passes"stouffer".method_modifierroxygen no longer offers"fisher"as a choice.The vendored
webgestalt_libstill has the variant, so this compiles as-is; it simply stops naming it.