Repository navigation
Add Home Assistant Platinum readiness work items - #36
Merged
Merged
Conversation
Closed
Co-authored-by: cabberley <26394346+cabberley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add additional work items for Platinum standard HA integration
Add Home Assistant Platinum readiness work items
Oct 9, 2026
cabberley
marked this pull request as ready for review
October 9, 2026 02:27
cabberley
approved these changes
Oct 9, 2026
Reviewer's GuideThis PR introduces a documented, acceptance-criteria-driven backlog for progressing toward Home Assistant Platinum quality, while preserving the existing feature ideas and linking the new roadmap from the README. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="PLATINUM_ROADMAP.md" line_range="77-80" />
<code_context>
+
+- Entity identifiers remain stable and entities expose correct device
+ association, availability, units, and state metadata where applicable.
+- Service schemas and descriptions match the accepted inputs and are covered
+ by tests; user-facing service and flow strings are translated.
+- Unsupported hardware capabilities and invalid control requests fail safely
+ with useful feedback.
+
+### 6. Complete user and maintainer documentation
</code_context>
<issue_to_address>
**Broken device triggers stay unplanned**
When a user selects either advertised device trigger, the roadmap’s audit criteria test service schemas but not device triggers. `async_get_triggers` advertises lowercase `offline` and `fault`, while `async_attach_trigger` checks title-case values, leaving `to_state` unset and causing trigger setup to fail.
Add an explicit device-trigger work item or acceptance criterion to correct the type handling and test trigger setup.
</issue_to_address>
### Comment 2
<location path="PLATINUM_ROADMAP.md" line_range="111-112" />
<code_context>
+readiness work:
+
+- Add control for the relays on SI model inverters.
+- Evaluate moving API authentication to Home Assistant-managed OAuth
+ credentials.
+- Add a service for bulk multi-day schedule and envelope creation.
</code_context>
<issue_to_address>
**OAuth migration loses implementation scope**
When the preserved feature backlog is read as work intended for delivery, the roadmap makes evaluating a move to Home Assistant-managed OAuth the backlog item, rather than implementing the migration, so the existing feature is no longer planned for delivery.
Keep conversion to Home Assistant-managed OAuth as the backlog item, with evaluation as a step if needed.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: PLATINUM_ROADMAP.md:80
Comment on lines
+77
to
+80
| - Service schemas and descriptions match the accepted inputs and are covered | ||
| by tests; user-facing service and flow strings are translated. | ||
| - Unsupported hardware capabilities and invalid control requests fail safely | ||
| with useful feedback. |
There was a problem hiding this comment.
🟡 Medium · Broken device triggers stay unplanned
When a user selects either advertised device trigger, the roadmap’s audit criteria test service schemas but not device triggers. async_get_triggers advertises lowercase offline and fault, while async_attach_trigger checks title-case values, leaving to_state unset and causing trigger setup to fail.
Add an explicit device-trigger work item or acceptance criterion to correct the type handling and test trigger setup.
Prompt for AI agents
In `PLATINUM_ROADMAP.md` at lines 77-80:
**Broken device triggers stay unplanned**
When a user selects either advertised device trigger, the roadmap’s audit criteria test service schemas but not device triggers. `async_get_triggers` advertises lowercase `offline` and `fault`, while `async_attach_trigger` checks title-case values, leaving `to_state` unset and causing trigger setup to fail.
Add an explicit device-trigger work item or acceptance criterion to correct the type handling and test trigger setup.
Comment on lines
+111
to
+112
| - Evaluate moving API authentication to Home Assistant-managed OAuth | ||
| credentials. |
There was a problem hiding this comment.
⚪ Low · OAuth migration loses implementation scope
When the preserved feature backlog is read as work intended for delivery, the roadmap makes evaluating a move to Home Assistant-managed OAuth the backlog item, rather than implementing the migration, so the existing feature is no longer planned for delivery.
Keep conversion to Home Assistant-managed OAuth as the backlog item, with evaluation as a step if needed.
Prompt for AI agents
In `PLATINUM_ROADMAP.md` at lines 111-112:
**OAuth migration loses implementation scope**
When the preserved feature backlog is read as work intended for delivery, the roadmap makes evaluating a move to Home Assistant-managed OAuth the backlog item, rather than implementing the migration, so the existing feature is no longer planned for delivery.
Keep conversion to Home Assistant-managed OAuth as the backlog item, with evaluation as a step if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository needs a concrete plan to progress toward the Home Assistant Platinum Integration Quality Scale. Its existing TODOs do not cover the quality and reliability work required.
Summary by Sourcery
Establish a concrete, acceptance-driven roadmap for improving Home Assistant Platinum integration readiness while preserving the existing feature backlog.
New Features:
Enhancements:
Documentation: