Skip to content

fix: align location-retrieval and location-verification with Commonalities r4.4 - #436

Merged
hdamker merged 14 commits into
camaraproject:mainfrom
hdamker:fix/commonalities-r4.4-location-retrieval-verification
Oct 6, 2026
Merged

hdamker merged 14 commits into
camaraproject:mainfrom
hdamker:fix/commonalities-r4.4-location-retrieval-verification

Conversation

@hdamker

@hdamker hdamker commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

correction

What this PR does / why we need it:

Brings location-retrieval and location-verification to Commonalities 0.9.0 (r4.4): bumps x-camara-commonalities, re-syncs the additional-error-responses template, migrates the four deprecated Generic<status> responses to their r4.4 catalogue equivalents, repoints the local 422 examples at the new shared example pools, and removes 8 unused schema aliases absorbed from #433. No declared error-code set changes — every migration is an exact-code-set $ref swap.

Which issue(s) this PR fixes:

Fixes #434

Special notes for reviewers:

CI is green apart from the two P-027 warnings and the S-211 findings this PR resolves; most items are not covered by any validation rule, so a passing pipeline should not be read as full r4.4 alignment on its own. The three renamed 422 identifier examples (GENERIC_422_*_IDENTIFIER_DEVICE) drop their local summary: lines because a $ref replaces the whole example object — that's the shape Commonalities designed, not an accidental loss.

Changelog input

fix: align location-retrieval and location-verification with Commonalities r4.4

Additional documentation

This section can be blank.

docs

bigludo7
bigludo7 previously approved these changes Sep 26, 2026

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @hdamker

maxl2287
maxl2287 previously approved these changes Oct 5, 2026

@jlurien jlurien left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Comment thread code/Test_definitions/location-retrieval.feature Outdated
Comment thread code/Test_definitions/location-verification.feature Outdated
Comment thread code/API_definitions/location-retrieval.yaml
Comment thread code/API_definitions/location-retrieval.yaml
Comment thread code/API_definitions/location-retrieval.yaml
Comment thread code/API_definitions/location-verification.yaml
Comment thread code/API_definitions/location-verification.yaml
Comment thread code/API_definitions/location-verification.yaml
Comment thread code/Test_definitions/location-verification.feature Outdated
Comment thread code/Test_definitions/location-retrieval.feature Outdated
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
@hdamker
hdamker dismissed stale reviews from maxl2287 and bigludo7 via 4c9dfd9 October 5, 2026 19:12
hdamker and others added 9 commits October 5, 2026 21:12
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>

@jlurien jlurien left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker
hdamker merged commit f61059c into camaraproject:main Oct 6, 2026
2 of 3 checks passed
@hdamker
hdamker deleted the fix/commonalities-r4.4-location-retrieval-verification branch October 6, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

correction Sync26 In scope for Sync26 Meta-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align location-retrieval and location-verification with Commonalities r4.4

4 participants