Skip to content

[Added / Changed / Removed] Updates for Commonalities r4.4 - #92

Merged
eric-murray merged 21 commits into
camaraproject:mainfrom
eric-murray:eric-murray-patch-3
Oct 15, 2026
Merged

eric-murray merged 21 commits into
camaraproject:mainfrom
eric-murray:eric-murray-patch-3

Conversation

@eric-murray

@eric-murray eric-murray commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Make additional changes now that common files are imported from Commonalities r4.4

  • Update error response schema to use new common schema or locally defined schema
    • Remove 403 INVALID_TOKEN_CONTEXT and 404 NOT_FOUND from device-reachability-status
    • Add 422 MULTIEVENT_COMBINATION_TEMPORARILY_NOT_SUPPORTED and PRIVATE_KEY_JWT_NOT_CONFIGURED for device-reachability-status-subscriptions subscription creation
    • Add 404 IDENTIFIER_NOT_FOUND for device-reachability-status-subscriptions subscription creation
  • Rename device-reachability-status.feature to device-reachability-status-getReachabilityStatus.feature
  • Add new test scenarios
    • @reachability_status_subscriptions_08_subscription_creation_initial_event
    • @reachability_status_subscriptions_09_Create_reachability_status_subscription_sync_with_accesstoken_sink_credential
    • @reachability_status_subscriptions_10_Create_reachability_status_subscription_sync_with_private_jwt_key_sink_credential_out_of_band_provisioning
    • @reachability_status_subscriptions_11_Create_reachability_status_subscription_sync_with_private_jwt_key_sink_credential_in_band_provisioning
    • @reachability_status_subscriptions_422.02_creation_with_private_jwt_key_not_configured
    • @reachability_status_subscriptions_03_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_access_token_sink_credential_returned
    • @reachability_status_subscriptions_04_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_private_jwt_key_sink_credential_returned
    • @device_reachability_status_429.01_Too_Many_Requests
    • @device_reachability_status_429.02_Quota_Exceeded
  • Renumber some test scenarios
  • subscriptionDetail is now a required subscription creation parameter
  • Fix examples

Which issue(s) this PR fixes:

Fixes #91

Special notes for reviewers:

None

Changelog input

 release-note
 - Updates for Commonalities r4.4

Additional documentation

None

Updated response references for various error codes and added new responses for Too Many Requests and Service Unavailable.
Updated response references for error handling and added new response for Too Many Requests or Quota Exceeded.
Added scenarios for initial event notification and various subscription creation methods with different sink credentials. Updated scenario identifiers for consistency.
Added scenarios for handling error code 429 due to too many requests and quota exceeded.
bigludo7
bigludo7 previously approved these changes Oct 2, 2026

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Updated the device reachability status subscription schema to make 'subscriptionDetail' a required property and changed 'totalPages' to 0.
Updated examples in the device reachability status feature file to correct the property name for network access identifier.
Updated scenario tags for error handling in device reachability status subscription deletion tests. Added placeholders for error scenarios without defined test cases.
Removed unused error code sections for 404 and 422.

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-murray
eric-murray merged commit 620cb8b into camaraproject:main Oct 15, 2026
2 checks passed
@eric-murray
eric-murray deleted the eric-murray-patch-3 branch October 15, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review error response schemas following deprecation of "Generic" error response schemas by Commonalities r4.4

2 participants