Skip to content

[Added / Changed / Removed] Updates for Commonalities r4.4 - #102

Merged
eric-murray merged 26 commits into
camaraproject:mainfrom
eric-murray:eric-murray-patch-3
Oct 15, 2026
Merged

[Added / Changed / Removed] Updates for Commonalities r4.4#102
eric-murray merged 26 commits into
camaraproject:mainfrom
eric-murray:eric-murray-patch-3

Conversation

@eric-murray

@eric-murray eric-murray commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Make additional changes now that common files are imported from Commonalities r4.4

  • Update error response schema to use new common schema or locally defined schema
    • Remove 403 INVALID_TOKEN_CONTEXT and 404 NOT_FOUND from device-roaming-status
    • Add 422 MULTIEVENT_COMBINATION_TEMPORARILY_NOT_SUPPORTED and PRIVATE_KEY_JWT_NOT_CONFIGURED for device-roaming-status-subscriptions subscription creation
    • Add 404 IDENTIFIER_NOT_FOUND for device-roaming-status-subscriptions subscription creation
  • Rename device-roaming-status.feature to device-roaming-status-getRoamingStatus.feature
  • Add new test scenarios
    • @roaming_status_subscriptions_09_subscription_creation_initial_event
    • @roaming_status_subscriptions_10_Create_roaming_status_subscription_sync_with_accesstoken_sink_credential
    • @roaming_status_subscriptions_11_Create_roaming_status_subscription_sync_with_private_jwt_key_sink_credential_out_of_band_provisioning
    • @roaming_status_subscriptions_12_Create_roaming_status_subscription_sync_with_private_jwt_key_sink_credential_in_band_provisioning
    • @roaming_status_subscriptions_422.02_creation_with_private_jwt_key_not_configured
    • @roaming_status_subscriptions_03_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_access_token_sink_credential_returned
    • @roaming_status_subscriptions_04_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_private_jwt_key_sink_credential_returned
    • @device_roaming_status_429.01_Too_Many_Requests
    • @device_roaming_status_429.02_Quota_Exceeded
  • Renumber some test scenarios
  • subscriptionDetail is now a required subscription creation parameter
  • Fix examples

Which issue(s) this PR fixes:

Fixes #103

Special notes for reviewers:

None

Changelog input

 release-note
 - Updates for Commonalities r4.4

Additional documentation

None

@eric-murray
eric-murray marked this pull request as draft September 14, 2026 16:21
@eric-murray
eric-murray marked this pull request as ready for review September 25, 2026 12:19
@eric-murray eric-murray changed the title Updates for Commonalities r4.4 [Added / Removed] Updates for Commonalities r4.4 Sep 25, 2026
@eric-murray eric-murray changed the title [Added / Removed] Updates for Commonalities r4.4 [Added / Changed / Removed] Updates for Commonalities r4.4 Sep 25, 2026
bigludo7
bigludo7 previously approved these changes Sep 25, 2026
View reviewed changes

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-murray
Refactor error scenario tags and clean up comments
e1c222e 
Updated scenario tags for error handling and removed unused sections.
@eric-murray
Clean up error codes and note undefined test scenarios
51b23e9 
Removed commented error codes 404 and 422 from the feature file and added a note about undefined test scenarios.
@eric-murray
Change 422 response reference for subscription conflicts
0eb8cc7 
Updated the reference for the 422 response in the device roaming status subscriptions API definition.
@eric-murray
Update subscription properties in feature file
158fbc0
@eric-murray
Fix typo in subscription notification property
f705dff
@eric-murray
Fix scenario tags to lowercase in feature file
fc3c56e
bigludo7
bigludo7 approved these changes Oct 9, 2026
View reviewed changes

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-murray
eric-murray merged commit 0d4c97c into camaraproject:main Oct 15, 2026
2 checks passed
@eric-murray
eric-murray deleted the eric-murray-patch-3 branch October 15, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigludo7 bigludo7 bigludo7 approved these changes
@sachinvodafone sachinvodafone Awaiting requested review from sachinvodafone sachinvodafone is a code owner
@akoshunyadi akoshunyadi Awaiting requested review from akoshunyadi akoshunyadi is a code owner

Assignees

No one assigned

Labels

Sync26

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review error response schemas following deprecation of "Generic" error response schemas by Commonalities r4.4

2 participants

@eric-murray @bigludo7