Repository navigation
Release Review: SimSwap r4.2 (rc Sync26) - #307
camara-release-automation[bot] wants to merge 13 commits into
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 0 hints | Profile: standard |
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
hdamker
left a comment
There was a problem hiding this comment.
Validation is clean, and the P-027 warnings from the discarded snapshot (#304) are fixed. A few CHANGELOG gaps against rc.1 remain. Most of them cancel out in the public release, which is compared with 0.3.0 / 2.1.0, so short entries are enough here:
Removed(both APIs): the error codes trimmed with the r4.4 error catalogue, as announced in the r4.1 CHANGELOG. For example:- sim-swap-subscriptions: "Error codes not applicable to this API:
400 OUT_OF_RANGE(GET /subscriptions),403 INVALID_TOKEN_CONTEXT,403 SUBSCRIPTION_MISMATCH,404 IDENTIFIER_NOT_FOUND,409 CONFLICT,409 INCOMPATIBLE_STATE,422 MULTIEVENT_*,422 UNSUPPORTED_IDENTIFIER,429 QUOTA_EXCEEDED" - sim-swap: "Error codes not applicable to this API:
404 NOT_FOUND,429 QUOTA_EXCEEDED,400 OUT_OF_RANGE(POST /retrieve-date)"
- sim-swap-subscriptions: "Error codes not applicable to this API:
Breaking changes(sim-swap-subscriptions):phoneNumberis no longer required in theswappedevent data. It is required in rc.1, so event receivers can no longer rely on it. Keep it underFixedas well.Changed(both APIs): the first entry is the PR title "Align Commonalities r4.4 to Sim Swap and Subscriptions", repeated in both API sections. It would be clearer to say what changed in each API, e.g. "Aligned with Commonalities r4.4 (0.9.0): error responses taken from the r4.4 error catalogue, mandatoryinfo.descriptionsections updated, by @albertoramosmonagas in #295".
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
|
Thanks @hdamker for the review & @albertoramosmonagas for the fixes. all suggestions applied. |
There was a problem hiding this comment.
@bigludo7 @albertoramosmonagas: Thanks for applying the first round of review comments. Could be merged as is.
Two optional suggestions: the breaking-change entry now says that phoneNumber was already optional in 0.3.0, so it reads as a revert of an rc.1 change and not as a new restriction; and the entries no longer have the fix: prefix from the PR title.
Beyond that I have filed #308 with cosmetic changes to be applied with the next edits.
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
|
@albertoramosmonagas What is your preference - Do we manage @hdamker #308 proposal within this RC (and discard) or we merge this one and craft a new RC? |
As far as I'm concerned, and since we have time to do it now, we can tackle it, does that sound good to you? That way, we won't have to wait for the next cycle. The changelog has already been reviewed, so once we have the other issue done, all we'd have to do is add one more item to this changelog copy-and-paste |
|
Yes work for me ! |
Release Review: r4.2 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
0.4.0-rc.20.4.0-rc.12.2.0-rc.42.2.0-rc.3Dependencies: Commonalities r4.4, ICM r4.2
Codeowner Actions
Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
The following actions and checks are done by a Release Management reviewer before approving the PR:
mainPR are collected as sub-issues of one issue titledRelease r4.2 review findings(see Recording review findings)Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r4.2-696080a