Skip to content

Clear the security audit and move the macOS jobs off the retired macos-14 runner - #15

Open
cameronrye wants to merge 2 commits into
mainfrom
build/rustsec-2026-11
Open

cameronrye wants to merge 2 commits into
mainfrom
build/rustsec-2026-11

Conversation

@cameronrye

@cameronrye cameronrye commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Description

cargo audit has failed on main since 2026-10-19, in the weekly run too, so it fails on every pull request. New RustSec advisories cover three crates of the TLS stack that webhooks, InfluxDB export, the Prometheus push gateway and the TUI/GUI service client use through reqwest, and the audit policy in .cargo/audit.toml also denies three more crates:

Crate Locked Finding Moves to
rustls 0.23.45 RUSTSEC-2026-0346, -0347, -0348, -0349 0.23.46
rustls-webpki 0.103.15 RUSTSEC-2026-0382 0.103.16
webpki-roots 1.0.9 RUSTSEC-2026-0381 1.0.10
tokio 1.53.1 RUSTSEC-2026-0386 (unsound) 1.53.3
async-executor 1.14.0 yanked 1.14.1
clipboard-win 5.4.1 yanked 5.4.2

Each moves to the next release that clears its finding, with cargo update -p <crate> --precise <version> on Rust 1.90, as #9 did for yoke-derive. Those six commands also make cargo choose older, already locked versions for sixteen range dependencies of other crates (windows-sys for thirteen of them, socket2 for quinn and quinn-udp, getrandom for tempfile). One more command, cargo update -p windows-sys@0.48.0 -p windows-sys@0.52.0 -p windows-sys@0.59.0 -p windows-sys@0.60.2 -p socket2@0.5.10 -p getrandom@0.3.4, which locks no package (each named version is already the newest of its series), puts those edges back as they were. So Cargo.lock differs from main in exactly the six versions and their checksums.

0.2.1 shipped the same six versions, and the yanked yoke-derive 0.8.3 that #9 replaced, so the changelog gets one bullet under Security.

The second commit moves the macOS jobs off macos-14, which GitHub retired on 2026-11-02: a job that asks for it is now cancelled before it starts ("The configuration 'macos-14-arm64-us-default' is not supported"), as the launchd refusal job was on this pull request's first run. The same label would have stopped the 0.3.0 release, because dist 0.31.0 builds aarch64-apple-darwin on macos-14 by default and release-macos-app.yml uses dist's runners. The launchd job and the app job now run on macos-15, and github-custom-runners in Cargo.toml moves dist's aarch64-apple-darwin build there too; x86_64-apple-darwin stays on macos-15-intel.

This comes before the pre-0.3.0 follow-up pull request, whose own lockfile change is limited to one line.

Related Issue

Found by the weekly Security Audit run on main (failing since 2026-10-19), and by this pull request's first CI run (the retired runner).

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • My code follows the project's coding standards
  • I have run cargo fmt and cargo clippy (no Rust code changed; clippy ran on the new lockfile, see Testing)
  • I have added tests that prove my fix/feature works (a lockfile change; the audit is the test)
  • All new and existing tests pass (cargo test --workspace)
  • I have updated documentation as needed (none needed)
  • I have updated CHANGELOG.md (if applicable)

Testing

  • The six cargo update -p <crate> --precise <version> commands on Rust 1.90 print one Updating <crate> vA -> vB line each; the seventh prints Locking 0 packages. Comparing the old and new lockfiles package by package: the six change version, nothing is added or removed, no dependency list changes, and git diff shows 12 changed lines (six versions, six checksums).
  • cargo audit 0.22: exit 0, no vulnerabilities, and only the seven unmaintained-crate warnings the policy allows (paste, proc-macro-error, proc-macro-error2, ttf-parser, zbus_names, zvariant, zvariant_derive).
  • macOS, Rust 1.90: cargo clippy --locked --workspace --all-targets --all-features -- -D warnings clean; cargo test --locked --workspace 1622 passed, 0 failed.
  • macOS, stable 1.99.1: cargo clippy --locked --workspace --all-targets -- -D warnings, with and without --all-features, clean (its one future-incompatibility note is proc-macro-error2 2.0.1's, as on main).
  • Linux (the CI image, Rust 1.90, arm64): clippy with --all-features clean; cargo test --locked --workspace with and without --all-features: 3298 passed, 0 failed.
  • Runners: dist 0.31.0's dist plan lists macos-15 for aarch64-apple-darwin (it listed macos-14 before) and every other runner unchanged; dist generate --check passes, so release.yml needs no change. actionlint, zizmor --offline and the pin and permission checkers pass on the two workflows; the deploy_files tests pass (21).

cargo audit has failed on main since 2026-10-19, in the weekly run
too: new RustSec advisories cover rustls 0.23.45 (RUSTSEC-2026-0346,
-0347, -0348 and -0349), rustls-webpki 0.103.15 (RUSTSEC-2026-0382)
and webpki-roots 1.0.9 (RUSTSEC-2026-0381), RUSTSEC-2026-0386 marks
tokio 1.53.1 unsound, and async-executor 1.14.0 and clipboard-win
5.4.1 were yanked. The audit policy denies all of them.

Each moves to the next release that clears it, with
cargo update -p <crate> --precise <version> on Rust 1.90: rustls
0.23.46, rustls-webpki 0.103.16, webpki-roots 1.0.10, tokio 1.53.3,
async-executor 1.14.1 and clipboard-win 5.4.2. Those commands also
moved sixteen range dependencies of other crates to older versions
already in the lock. A cargo update of exactly those older versions,
each already the newest of its series, locks no package and moves the
edges back, so the lock differs from main in the six versions and
their checksums only.

The changelog's Security section names the advisories, and the
yanked yoke-derive 0.8.3 that 0.2.1 also shipped.

Checked: cargo audit exits 0 with only the seven unmaintained
warnings; on macOS, clippy on Rust 1.90 and stable and the workspace
tests on 1.90; in the Linux CI image, clippy and the workspace tests
with and without all features.
GitHub retired the macos-14 runner image on 2026-11-02: a job that
asks for it is cancelled before it starts ("The configuration
'macos-14-arm64-us-default' is not supported"). That cancelled the
launchd refusal job of the Deployment files workflow on this pull
request, and it would stop the 0.3.0 release: dist 0.31.0 builds
aarch64-apple-darwin on macos-14 by default, and the macOS app job
uses the same runners as dist.

The launchd job and the app job now run on macos-15, and
github-custom-runners moves dist's aarch64-apple-darwin build there
too. x86_64-apple-darwin stays on macos-15-intel.

Checked: dist 0.31.0's plan lists macos-15 for aarch64-apple-darwin
and every other runner unchanged, and dist generate --check passes,
so release.yml stays as it is; actionlint, zizmor --offline and the
pin and permission checkers pass; the deploy_files tests pass.
@cameronrye cameronrye changed the title build: update the six locked crates that fail the security audit Clear the security audit and move the macOS jobs off the retired macos-14 runner Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant