Skip to content

Fix for unit test TestFormatWithInlineCryptoEngine failing (#573) - #576

Merged
AVAM16 merged 1 commit into
canonical:masterfrom
AVAM16:TestFormatWithInlineCryptoEngine_Fix
Sep 30, 2026
Merged

AVAM16 merged 1 commit into
canonical:masterfrom
AVAM16:TestFormatWithInlineCryptoEngine_Fix

Conversation

@AVAM16

@AVAM16 AVAM16 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Test fix for #573 :

go test ./internal/luks2 -check.v -check.f TestFormatWithInlineCryptoEngine

One line addition, adding:

s.AddCleanup(ResetCryptsetupFeatures)

in the beginning of the function:

func (s *cryptsetupSuiteBase) SetUpTest(c *C)

in the file internal/luks2/cryptsetup_test.go.

@AVAM16 AVAM16 self-assigned this Sep 29, 2026

@ruifm ruifm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@frederic-hoerni
frederic-hoerni self-requested a review September 30, 2026 06:18
@frederic-hoerni

Copy link
Copy Markdown
Collaborator

Please add more description in the commit message: keep the link to #573, but also describe the modification so that someone with no access to #573 will still understand.

@frederic-hoerni frederic-hoerni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as said in the other pane) Please add more description in the commit message: keep the link to #573, but also describe the modification so that someone with no access to #573 will still understand.

@AVAM16
AVAM16 force-pushed the TestFormatWithInlineCryptoEngine_Fix branch from 5040d05 to 4a2a60c Compare September 30, 2026 08:07
@AVAM16

AVAM16 commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

Improved the commit message

@AVAM16
AVAM16 merged commit 7e35186 into canonical:master Sep 30, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants