Repository navigation
chore: split editor shell + project standards - #28
Merged
Merged
Conversation
Split App.tsx below the architecture file-size cap by moving TitleSlideDialog, SlideSettingsDialog, and slide JSON helpers into dedicated modules. Behavior unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace broken references to generic cross-repo standards templates with a single slideshow-focused doc. Point CLAUDE.md, composition-patterns, and code-reviewer at it. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TitleSlideDialog,SlideSettingsDialog, andslidePersistence.tsfromApp.tsx(612 → 311 lines).composition-patternsskill (3 applicable Vercel rules) for future editor-shell work.standards/references with a single project-specificstandards/slideshow.md.CLAUDE.md,composition-patternsskill, andcode-revieweragent to point at the new doc.Acceptance criteria
This is a maintenance/refactor PR (no linked issue).
App.tsxunder the 300-line architecture cap (311 — dialog/persistence split; remainder is App orchestration)TitleSlideDialog/SlideSettingsDialog)standards/slideshow.mddocuments only what applies to this Vite SPApnpm lint,pnpm test,pnpm buildpassCode review
Score: 5/5
Blocking findings: none
Non-blocking:
App.tsxis 11 lines over the 300-line target if counting strictly; further split would mean extracting folder-load hooks.Decision: APPROVE
Test plan
pnpm lintpnpm test(121 tests)pnpm build/Made with Cursor