Repository navigation
Slice 14 — Jamendo search, preview, download (#15) - #35
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Summary
src/jamendo/module:client.ts(API search),download.ts(file download + sanitize),types.ts(JamendoTrack,JamendoAttribution), all tested against mocked fetch responses (11 tests).JamendoPanel.tsx: search form, results list (title/artist/duration), per-track preview play/stop viaHTMLAudioElement, Add button that downloads to project folder and sets attribution. Error/empty states both show fallback hint.App.tsx:handleJamendoAdddownloads track, re-enumerates audio, sets filename + attribution;loadFolderrestores attribution (cleared when soundtrack file no longer valid); autosave includes attribution.slidePersistence.ts:slidesToJsonextended withsoundtrackAttribution?param.schema.ts:SlideshowJsonextended withsoundtrackAttribution?: JamendoAttribution.env.d.ts:VITE_JAMENDO_CLIENT_IDtyped. Panel renders only when env var is set.Acceptance criteria
handleJamendoAdddownloads via File System Access API, re-enumerates, sets state; attribution serialized inslideshow.json.Code review verdict
APPROVED after fixing 8 findings:
audio.play()rejection now caught;previewIdreverts to null on autoplay blockonendedcleared before replacingaudioRef.currenthandleAddnow surfaces download errors in UIenumerateAudioTracksfailure after successful download surfaced viasetErrordownloadTrackrejects non-audio responsesslidePersistence.test.ts: added truthy + null tests forsoundtrackAttribution🤖 Generated with Claude Code