Repository navigation
Slice 16 — Playback controls + fullscreen (#17) - #38
Merged
Merged
Conversation
Wire grid playhead highlighting to RenderPlan frame positions, seek on slide click, and a body-portaled Present mode that hides editor chrome. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Summary
sequence-planner/playbackhelpers map playhead frames ↔ slide IDs from theRenderPlanrequestAnimationFramepolling; click seeks to that slide and opens settingsdocument.body, requests fullscreen, hides editor chrome; Esc exitsAcceptance criteria
SlideshowCompositiondriven byRenderPlan(no separate render path)Code review
Score: 4/5 — APPROVE
Frame→slide logic correctly lives in the pure module; editor shell stays thin. No determinism concerns. Tests cover
slideIdAtFrame/startFrameForSlideIdgolden cases.Non-blocking follow-ups: rAF poll runs while paused (fine at editor scale);
slideIdAtFrameuses start-frame semantics so crossfade overlap may briefly highlight the incoming slide before it visually dominates; presentation mode remounts the player (playback state preserved viainitialFrame).Test plan
pnpm testpnpm buildpnpm lintnode scripts/playwright-issue-17-smoke.mjs(requires dev server)Made with Cursor