Version 6.3.0

.claude/skills/build-installer.md

@@ -0,0 +1,68 @@
+---
+description: Build the FastFlix installer, distribution, launcher, and uninstaller
+---
+
+# Building the FastFlix Installer & Distribution
+
+## Prerequisites
+
+- Go 1.22+ installed
+- `go-winres` installed (pinned): `go install github.com/tc-hib/go-winres@v0.3.3`, with `%GOPATH%\bin` on PATH
+- Python 3.13+ with `uv`
+- Internet access (first build downloads embeddable Python and wheels)
+
+`zstandard` is not a project dependency; run the script through `uv run --with zstandard`.
+
+## Full Build (everything from scratch)
+
+```bash
+uv run --with zstandard python scripts/build_distribution.py --archive --installer
+```
+
+This produces `dist/FastFlix_installer.exe`. The script:
+- Downloads the embeddable Python (version constant `DEFAULT_PYTHON_VERSION` in the script)
+- Builds a fresh FastFlix wheel (wipes `dist/wheels`, requires exactly one wheel)
+- Installs dependencies pinned from `uv.lock` for the bundled CPython 3.13 / win_amd64 (`--arch arm64` for ARM64)
+- Syncs `cmd/*/winres/winres.json` with `fastflix/version.py` (versions + copyright year)
+- Runs `go-winres make` in each `cmd/*` and builds `FastFlix.exe` + `uninstall.exe` (+ installer with `--installer`)
+  with `-X main.Version=... -X main.BuildDate=...`
+- Trims unused PySide6 modules (~527 MB savings), keeping third-party licence files
+- Creates `fastflix_dist.tar.zst`, copies `licenses.txt`, generates `terms_translations.json`
+
+Use `--archive` alone to stop before building the installer.
+
+## Manual rebuilds (after Go code changes)
+
+Run `go-winres make` in the `cmd/<name>` directory first (the `.syso` files are gitignored), then:
+
+```bash
+go build -ldflags="-s -w -X main.Version=6.3.0 -X main.BuildDate=2026-01-01" -o dist/FastFlix/FastFlix.exe ./cmd/launcher
+go build -ldflags="-s -w -H windowsgui -X main.Version=6.3.0" -o dist/FastFlix/uninstall.exe ./cmd/uninstaller
+go build -ldflags="-s -w -H windowsgui -X main.Version=6.3.0 -X main.BuildDate=2026-01-01" -o dist/FastFlix_installer.exe ./cmd/installer   # needs the archive
+```
+
+## Checks
+
+```bash
+GOOS=windows go vet ./...
+go test ./cmd/internal/...
+```
+
+## Important Notes
+
+- **Launcher**: Built WITHOUT `-H windowsgui` (needs console for logs); passes all arguments through to `python -m fastflix`
+- **Installer/Uninstaller**: Built WITH `-H windowsgui` (no console)
+- **Shared logic** (path safety, manifest-based removal, registry, self-delete batch) is in `cmd/internal/ffinstall`; never delete directories with `RemoveAll` on a registry-derived path without `ffinstall.SafeToRemove`
+- **Uninstall** removes only files listed by `install_manifest.txt` (top-level entries) and keeps user files like a portable `fastflix.yaml`
+- **DO NOT** use `CREATE_NO_WINDOW` flag on the launcher's child process - breaks FFmpeg pipe handles
+- **DO NOT** use `walk` or other Go GUI frameworks - they have `TTM_ADDTOOL` failures on modern Windows. Use raw Win32 API.
+- For `WM_DRAWITEM`-style lParam casts use `*(**T)(unsafe.Pointer(&lParam))` (keeps `go vet` clean)
+
+## Testing
+
+```bash
+dist/FastFlix/FastFlix.exe --version
+dist/FastFlix/FastFlix.exe --test
+dist/FastFlix_installer.exe
+"%LOCALAPPDATA%\Programs\FastFlix\uninstall.exe"
+```

.github/workflows/build.yaml

@@ -96,41 +96,41 @@ jobs:
       run: |
         mkdir dist
         New-Item -Path Env: -Name VERSION -Value $(python.exe scripts\get_version.py)
-        New-Item -Path Env: -Name EXACT_VERSION -Value $(python.exe scripts\get_version.py exact)
-        New-Item -Path Env: -Name PRODUCT_VERSION -Value $(python.exe scripts\get_version.py nsis)
         echo "Building branch $env:GITHUB_REF - version $env:VERSION"
         echo "::set-env name=VERSION::$env:VERSION"
-        echo "::set-env name=EXACT_VERSION::$env:EXACT_VERSION"
-        echo "::set-env name=PRODUCT_VERSION::$env:PRODUCT_VERSION"
       env:
         ACTIONS_ALLOW_UNSECURE_COMMANDS: true
 
+    - name: Set up Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: "1.24"
+        cache-dependency-path: go.sum
+
+    - name: Install go-winres (icon / manifest / version resources)
+      shell: bash
+      run: |
+        go install github.com/tc-hib/go-winres@v0.3.3
+        echo "$(go env GOPATH)/bin" >> "$GITHUB_PATH"
+
     - name: Install Python Dependencies
       run: uv sync --frozen
 
-    - name: Build single executable
+    # Builds python runtime + dependencies (pinned by uv.lock), runs go-winres for the launcher and
+    # uninstaller, builds FastFlix.exe + uninstall.exe, writes cmd/installer/fastflix_dist.tar.zst, then
+    # runs go-winres for the installer and builds dist\FastFlix_installer.exe with
+    # -ldflags "-s -w -H windowsgui -X main.Version=<fastflix/version.py> -X main.BuildDate=<today>".
+    - name: Build distribution and installer
       shell: cmd
-      run: uv run pyinstaller FastFlix_Windows_OneFile.spec
+      run: uv run --with zstandard python scripts\build_distribution.py --archive --installer
 
-    - name: Build installer executable
+    - name: Go vet
       shell: cmd
-      run: uv run pyinstaller FastFlix_Windows_Installer.spec
-
-#    - uses: skymatic/code-sign-action@v1
-#      with:
-#        certificate: '${{ secrets.CODE_CERT_B64 }}'
-#        password: '${{ secrets.CODE_CERT_PASS }}'
-#        certificatesha1: '${{ secrets.CODE_CERT_THUMB }}'
-#        description: 'FastFlix'
-#        timestampUrl: 'http://timestamp.sectigo.com'
-#        folder: 'dist\FastFlix'
-#        recursive: false
+      run: go vet ./...
 
-    - name: Package installer
+    - name: Go tests
       shell: cmd
-      run: |
-        makensis.exe /INPUTCHARSET UTF8 /DVERSION=${{ env.EXACT_VERSION }} /DPRODUCT_VERSION=${{ env.PRODUCT_VERSION }} FastFlix.nsi
-        move FastFlix_installer.exe dist\FastFlix_${{ env.VERSION }}_installer.exe
+      run: go test ./cmd/internal/...
 
 #    - uses: skymatic/code-sign-action@v1
 #      with:
@@ -140,29 +140,29 @@ jobs:
 #        description: 'FastFlix'
 #        timestampUrl: 'http://timestamp.sectigo.com'
 #        folder: 'dist'
-#        recursive: false
+#        recursive: true
 
-    - name: Test executable
+    - name: Test launcher
+      shell: cmd
       run: |
-        dist\FastFlix.exe --version
-        dist\FastFlix.exe --test
+        dist\FastFlix\FastFlix.exe --version
+        dist\FastFlix\FastFlix.exe --test
 
-    - name: Package single executable
+    - name: Package installer and portable archive
       shell: cmd
       run: |
-        move dist\*.exe .
-        move docs\build-licenses.txt LICENSE
+        move dist\FastFlix_installer.exe dist\FastFlix_${{ env.VERSION }}_installer.exe
+        copy docs\build-licenses.txt dist\FastFlix\LICENSE
+        7z a -mm=Deflate -mfb=258 -mpass=15 dist\FastFlix_${{ env.VERSION }}_win64.zip .\dist\FastFlix\*
 
-    - name: Upload standalone executable artifact
+    - name: Upload portable archive artifact
       uses: actions/upload-artifact@v4
       with:
         name: FastFlix_${{ env.VERSION }}_win64
-        path: |
-          FastFlix.exe
-          LICENSE
+        path: dist/FastFlix_${{ env.VERSION }}_win64.zip
 
     - name: Upload installer artifact
       uses: actions/upload-artifact@v4
       with:
         name: FastFlix_${{ env.VERSION }}_installer
-        path: FastFlix_${{ env.VERSION }}_installer.exe
+        path: dist/FastFlix_${{ env.VERSION }}_installer.exe

.github/workflows/test.yaml

@@ -48,4 +48,5 @@ jobs:
     - name: Run tests
       env:
         PYTEST_QT_API: pyside6
+        QT_QPA_PLATFORM: offscreen
       run: uv run pytest tests -v

.gitignore

@@ -125,4 +125,13 @@ iso-639-3.*
 build-dir/
 benchmarking/
 
-./.claude/settings.local.json
+.claude/settings.local.json
+
+# Go installer build artifacts
+cmd/installer/fastflix_dist.*
+cmd/*/*.syso
+cmd/installer/licenses.txt
+cmd/installer/terms_translations.json
+
+# Build script cache (downloaded Python embeddable, get-pip.py)
+scripts/cache/