Repository navigation
Fix PyInstaller LD_LIBRARY_PATH contamination breaking FFmpeg on Linux - #766
Merged
Merged
Conversation
Add clean_env function to remove LD_LIBRARY_PATH from environment.
Added clean_env() to subprocess calls for feature checks.
Updated the run method to include a clean environment for subprocesses.
Pass cleaned environment to subprocess run for thumbnail generation.
Updated thumbnail generation to use a cleaned environment.
Updated thumbnail generation to use a cleaned environment.
|
Verified independently that this PR fixes the latest version on Arch. Arch's native built AUR package is still broken, but that's not your problem to deal with, unless you want to take that on as well. |
* Resolve shared.py conflict with the Go launcher detection added on develop * Move clean_env to the Qt-free fastflix.resources (re-exported from fastflix.shared) so the conversion worker process does not import PySide6 * Restore PyInstaller's LD_LIBRARY_PATH_ORIG instead of always dropping LD_LIBRARY_PATH * Apply clean_env to hdr10plus_tool calls, the crop preview retry, HDR10+ inject and xdg-open * Add tests and changelog entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running from a PyInstaller-built binary (e.g. the
fastflix-binAUR package), FFmpeg fails to launch with:/usr/bin/ffmpeg: symbol lookup error: /usr/lib/libass.so.9: undefined symbol: FcConfigSetDefaultSubstitutePyInstaller sets
LD_LIBRARY_PATHto its bundled library directory at startup.When FastFlix spawns
/usr/bin/ffmpegas a subprocess, FFmpeg inherits this contaminated path and loads the bundledlibass.so(built for Ubuntu 24.04) instead of the system one, causing a symbol mismatch with the systemfontconfig.This affects any Linux distribution where the system library versions differ from those bundled in the PyInstaller binary.
Added a
clean_env()helper infastflix/shared.pythat stripsLD_LIBRARY_PATHfrom the environment when running in a frozen PyInstaller app.This is applied to all subprocess calls (run, Popen) that invoke FFmpeg, FFprobe, or related tools