fix: refactor process collection to centralize kotlin filtering - #136
Merged
cdsap merged 1 commit intoSep 19, 2026
Merged
Conversation
cdsap
deleted the
issue/135-hermes-refactor-process-collection-to-centr-a1
branch
September 19, 2026 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
InfoKotlinProcessBuildService.kt:22-27 and DevelocityWrapperConfiguration.kt:33-38 independently call ConsolidateProcesses with TypeProcess.Kotlin, duplicating core process-collection behavior across the console and Develocity paths.
Why this matters
The two reporting adapters can drift in parser configuration or process filtering, while the duplicated infrastructure dependency makes the shared behavior harder to test in isolation.
Proposed change
Introduce a small KotlinProcessCollector component that owns ConsolidateProcesses and the Kotlin process-type selection. Have both reporting paths delegate to it while retaining their existing Provider resolution and output behavior.
Notes
This creates a narrow core/application boundary: Gradle lifecycle and reporting integrations remain adapters, while Kotlin-process consolidation becomes shared behavior that can be tested independently. Current ktlintCheck passed; the existing test task currently reports 8 failures in output assertions before this proposal is applied.
Fixes #135
Changes
plugin/src/test/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollectorOwnershipTest.ktVerification
./gradlew ktlintCheck./gradlew test