blockdev: Add list_dev_by_dir_optional - #33
Closed
cgwalters-bot wants to merge 1 commit into
Closed
cgwalters-bot wants to merge 1 commit into
cgwalters-bot wants to merge 1 commit into
Conversation
cgwalters
approved these changes
Sep 29, 2026
bootupd needs to tell "this filesystem has no backing block device" (virtiofs in bcvk ephemeral, NFS root, ...) apart from real errors when finding the device for /boot or /sysroot, so it can skip the bootloader update in the first case. Guessing from the findmnt source string is fragile; the kernel already says it via st_dev, since filesystems without a block device get an anonymous device number with major 0. btrfs and ZFS are the exceptions: they get anonymous device numbers too although they sit on block devices, so recognize them by their statfs magic and resolve them the way list_dev_by_dir already does (findmnt's source for btrfs, the zpool members for ZFS since f61730b). Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
Collaborator
Author
|
Signed off 1 commit(s) with |
cgwalters-bot
force-pushed
the
bot/blockdev-optional-dev
branch
from
September 29, 2026 21:42
d17fa14 to
ee01e4d
Compare
Collaborator
Author
|
Opened upstream as bootc-dev#2517. Closing this review draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
list_dev_by_dir_optional(), which returnsNonewhen the filesystem mounted at a directory has no backing block device instead of failing in lsblk. bootupd needs this to skip the bootloader update on virtiofs (bcvk ephemeral), NFS roots and the like while still failing on real errors (coreos/bootupd#1163).The check is
st_dev: filesystems without a block device get an anonymous device number (major 0). btrfs and ZFS also get anonymous numbers although they are block-backed, so they are recognized by statfs magic and resolved aslist_dev_by_diralready does (ZFS support there is from f61730b, bootc#1240).Tested on a 16-core devspace:
cargo test -p bootc-internal-blockdev,cargo clippy -p bootc-internal-blockdev --all-targets -- -D warningsandjust validatepass.Generated-by: https://github.com/cgwalters/#llms
Review draft in cgwalters-forge, not upstream yet. This section is removed when the PR is opened upstream.
bootc-dev/bootc, basemainPVTI_lAHOAQ_SPs4Bj2Gizg9iDPATo review:
/promoteon a line of its own, to open it upstream, ready for review. Either covers only the commits pushed so far.Signed-off-by: Colin Walters <walters@verbum.org>to the commits lacking it (the bot's and yours; anyone else's only if you ask), with you as committer./draftline (in the same comment or before) to open it upstream as a draft (/readyundoes that).