Repository navigation
Security: Restrict REST course self-enrolment - refs GHSA-qc88-h6gp-4gcg - #9237
Merged
christianbeeznest merged 1 commit intoOct 16, 2026
Conversation
christianbeeznest
force-pushed
the
security/auto-fix-GHSA-qc88-h6gp-4gcg
branch
from
October 15, 2026 22:13
d932202 to
1be9416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REST v2 self-subscription accepted the requested course status while calling CourseManager::subscribeUser() with checkTeacherPermission=false.
That flag was intentionally introduced for administrative webservice operations, so platform administrators keep the existing behavior. Normal REST users may still subscribe themselves, but the server now forces STUDENT and uses the regular course self-subscription flow, which applies the course registration rules.
Verified against a running 1.11.x instance:
The historical checkTeacherPermission=false behavior is therefore preserved for administrative webservice use only.
Refs GHSA-qc88-h6gp-4gcg