Repository navigation
Security: Restrict REST course write actions - refs GHSA-hgqr-52jh-f6j7 - #9239
Merged
christianbeeznest merged 1 commit intoOct 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REST v2 course write actions trusted the client-selected course context and allowed forum/notebook writes without validating that the authenticated user belonged to the selected course or session.
This change adds a common authorization guard to:
Platform administrators keep their existing access.
For normal course access, the authenticated user must be subscribed to the selected course.
For session context, the selected session must belong to the course and the user must have an allowed course/session role. Read-only and invisible sessions are rejected for non-teachers.
Verified against a running 1.11.x instance:
The legacy REST endpoint serializes authorization failures as HTTP 200 with error=true; this change fixes the authorization and unauthorized persistence issue without changing that existing transport behavior.
Session-specific role branches were reviewed but were not exercised in the runtime test.
Refs GHSA-hgqr-52jh-f6j7