Repository navigation
Security: Restrict REST class management - refs GHSA-4335-6683-mvwx - #9242
Merged
christianbeeznest merged 1 commit intoOct 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REST v2 class-management endpoints allowed any authenticated API user to inspect and modify class membership and course/session bindings.
This could be used by a regular student to add users to arbitrary classes or bind courses to classes. Course bindings can cascade into course enrollments through UserGroup::subscribe_courses_to_usergroup().
This change protects the following administrative endpoints with the existing protectAdminEndpoint() guard:
add_group and delete_group were already protected and were not changed.
Verified against a running 1.11.x instance:
No existing session was available in the local test database, so the positive add/delete class-session binding path was not exercised at runtime. The non-admin session-binding endpoints were verified as rejected.
The legacy REST endpoint returns authorization failures as HTTP 200 with error=true; this change preserves that existing transport behavior.
Refs GHSA-4335-6683-mvwx