feat(group): add Validate for cross-field group validation - #817
Open
ChrisJr404 wants to merge 1 commit into
Open
feat(group): add Validate for cross-field group validation#817ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #386.
huh lets you validate individual fields, but there was no way to validate a group as a whole. This adds
Group.Validate(func() error)that runs when the form tries to advance past the group. If it returns an error the form stays put and shows the message, just like a field error does.It's meant for checks that span more than one field, like confirming two inputs match or that a date range makes sense. The func closes over your bound values, so you can look at whatever you need:
Groups without a Validate behave exactly as before. The error clears when you go back a group, and it re-runs every time you try to move forward, so fixing the input and advancing again just works.
This only covers the synchronous case from the issue. I left the async/spinner idea out since that's a bigger design question, happy to look at it separately if you want it.