fix: dclogin links for IP addresses need square brackets - #20
Merged
Conversation
7 tasks
j4n
approved these changes
Apr 23, 2026
j4n
left a comment
j4n
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, works for pinging my new v4 relay as well :)
missytake
force-pushed
the
dclogin-no-dns
branch
from
April 23, 2026 12:44
78d9a8d to
0355eb9
Compare
hpk42
reviewed
Jul 27, 2026
hpk42
approved these changes
Jul 27, 2026
hpk42
left a comment
hpk42
left a comment
Contributor
There was a problem hiding this comment.
please do:
- the bugfix (see comment)
- rebase on main
- a single commit in git-cliff style
After CI passes with these changes (and your manual tests), you can merge :)
Co-authored-by: j4n <j4n@systemli.org>
missytake
force-pushed
the
dclogin-no-dns
branch
from
July 29, 2026 08:07
0355eb9 to
84e3467
Compare
Contributor
Author
I prefer doing separate commits for easier review, and then squash-merge so the resulting commit is in git-cliff style :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to chatmail/relay#919 (review)
Not sure if the second commit should be in this PR, or why it's 12 by default; I think it just wasn't used until now? Anyway, as I see no way to set the value from chatmail.ini, let's just use the default value 9.