Repository navigation
pool: honor CleanOnFinish when rendering bars - #246
Closed
team-humaki wants to merge 1 commit into
Closed
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
Skip finished CleanOnFinish bars in Pool.print and wipe leftover lines so they actually disappear from the pool frame. Fixes cheggaaa#223
Owner
|
Closing: superseded by #249, which also stops the own writer of a bar started before Pool.Add and erases the lines of hidden bars. Thanks for the report and the first fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool.print always rendered every bar, so CleanOnFinish only cleared the root and child bars stuck on screen after Finish().
Skip finished CleanOnFinish bars in the unix/windows pool printers and wipe leftover lines when the visible count shrinks. Added a small pool regression test.
Fixes #223