Repository navigation
fix: properly clear finished bars when CleanOnFinish is enabled in pool - #252
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
When progress bars within a Pool have CleanOnFinish enabled, finishing bars or stopping the pool failed to clear completed bar lines during redraw cycles. The pool print routine unconditionally rendered all bars and left trailing output when the number of visible bars decreased. Update Pool.print to: - Filter out completed bars where CleanOnFinish is true. - Clear trailing lines with blank spaces when active bar count decreases. - Reposition cursor back to the bottom of the remaining active bars. - Properly update lastBarsCount and prune finished CleanOnFinish bars. - Add regression tests covering single-bar and multi-bar pool cleanups. Fixes cheggaaa#223.
Author
|
Closing in favor of maintainer PR #249 to keep the review queue clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When progress bars within a Pool have CleanOnFinish enabled, finishing individual bars or stopping the pool leaves trailing bar lines during pool redraw cycles because Pool.print does not account for CleanOnFinish and unconditionally renders all bars.
Changes
Fixes #223.