Repository navigation
v3: finish the bar started in TestProgressBarTemplate - #259
Merged
Merged
Conversation
Its writer kept running into later tests and read the terminalWidth global while TestPBMaxWidth replaced it, so go test -race -count=3 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestProgressBarTemplatestarts a bar and never finishes it. The bar's writer keeps running into later tests and reads theterminalWidthglobal whileTestPBMaxWidthreplaces it, sogo test -race -count=3 ./...fails (3 of 3 runs on master). With the bar finished,-race -count=5passes 5 of 5 runs and-race -count=20passes.CI runs without
-race, so it never saw this.🤖 Generated with Claude Code