Repository navigation
Fail pinned model calls that return a refusal-of-service notice - #84
Merged
Merged
Conversation
With the Argo monthly quota exhausted (2026-10-09), every refiner call through the shared pinned transport "succeeded" in about one second with Argo's "IMPORTANT USAGE NOTICE FROM ARGO … ACCESS REVOKED … Monthly limit exceeded" text as the reply, and that text became refiner input. chian#79 detected such notices only in the chat coding adapter. - agent/provider_notices.py: provider_notice() recognizes a refusal when a short reply (<= 4000 chars) carries at least two distinct markers (notice from Argo, access revoked, usage/monthly limit exceeded, quota exceeded, contact your Directorate Operations Officer); one marker alone, as in a genuine answer discussing quotas, is not enough. - episode_launch_transport._invoke raises ProviderRefusedService for such a reply, so the pinned call fails visibly (Designer, Materialization Implementer, Builder, Target Workflow calls). It is not a dropped connection, so the supervisor does not replace it. - The chat coding adapter uses the same detector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #79.
Problem
With the user's Argo monthly quota exhausted (2026-10-09), a
/buildon a session still pinned to Argo produced a run of refiner calls that each "succeeded" in about 1 s:launch→physical_attempt_succeeded. Each reply was Argo's notice:That text was returned with HTTP 200 as the assistant message and fed into the refiner's working context. #79 only detected such notices inside the chat coding adapter.
Change
New
agent/provider_notices.py:provider_notice(text)recognizes a refusal when a short reply (≤ 4000 characters) contains at least two distinct markers:A genuine answer that merely mentions a quota has one marker at most and isn't flagged.
agent/episode_launch_transport._invokeraisesProviderRefusedService("Provider refused service: …")for such a reply. This covers every pinned call: the Designer and refiner roles, the Materialization Implementer, Builder planning and emission, and Target Workflow model calls. The failure is recorded through the normalphysical_attempt_failedpath. It's not a dropped connection, so the Replace a model attempt whose connection dropped mid-response (ADR 0008 amendment) #76 supervisor does not replace it.The chat coding adapter now uses the same detector; its duplicated markers are removed.
Tests
tests/agent/test_provider_notices.py, 8 tests:None, and long text;invoke_pinned_routeraiseProviderRefusedServiceafter one call;Unchanged and passing:
test_refinement_chat_coding(18),test_episode_model_failure_reporting(5),test_launch_transport_streams(4),test_model_call_failed_attempt_replacement(7),test_model_call_liveness(8).🤖 Generated with Claude Code