Repository navigation
T3: ToolFailureCause factory for turn-path errors - #267
Merged
Merged
Conversation
One cause->AgentError factory fed by per-adapter cause tables: FM string-fallback rows, OpenAI status rows, retryability URL-code set. Shared cancellation guard, retryAfter derivations (removing the FM resetDate duplication and the OpenAI header parser copy), and description matching. Behavior-identical; pinned by table-driven tests.
List in-scope turn-path call sites and out-of-scope origins (inference factory, tool-side synthesis, bridging, legacy executor, provider-owned loops, graph runtime). Document the deliberate absence of a CancellationError guard with a pinning test.
Pin exact stopOnToolError batch messages, multi-call first-failure-wins, and engine-throw vs recorded-transcript message equivalence.
christopherkarani
marked this pull request as ready for review
October 2, 2026 00:38
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: spec/spec-architecture-agent-turn-history-errors.md
Ticket: T3 (arch/error-cause-factory)
What changed (vs origin/main, 4 commits):
Files: ToolFailureCause.swift (new), Agent+ToolLoop.swift, Agent+ToolLoopHandoffs.swift, EventStreamHooks.swift, ToolExecutionEngine.swift, ToolExecutionResult.swift, ToolRegistry.swift, + tests
Review passes done: branch self-review-fix commit included; no final verified review evidence available to PR agent, so opened as draft.
Intended behavior change (reviewed, pinned by tests)
stopOnToolError batch throw now nests the registry toolFailure as
causeinstead of dropping it (previouslycause:nil). This fixes a dropped-cause bug; exact messages are pinned. Retryability unaffected (.toolFailure unconditionally non-retryable).